Adding Selection Controls
#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rookiejava
reviewed
Apr 22, 2019
Contributor
rookiejava
left a comment
rookiejava
left a comment
There was a problem hiding this comment.
The color of dark mode looks differernt. please check the color of dark mode once again.
https://material.io/design/components/selection-controls.html#switches
Plus, do not change the file mode (644 -> 755)
Contributor
Author
|
I thought the theme colors depend on how its defined by the platforms or the users. |
rookiejava
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implementation of
Selection Controls, the new Material Component.Selection Controlsincludes...fixes #24
API Changes
New class implementation for
Selection Controls.Screenshots