Add MList #44
Add MList #44
Conversation
| TripleLine | ||
| } | ||
|
|
||
| public class MItem |
There was a problem hiding this comment.
Create MItem.cs for MItem class.
|
|
||
| public EvasObject Control { get; set; } | ||
|
|
||
| public MItem(string title, MListStyle style = MListStyle.OneLine) |
There was a problem hiding this comment.
Any reason to provide optional parameter only for style?
|
|
||
| public EvasObject Control { get; set; } | ||
|
|
||
| public MItem(string title, string icon = null) |
There was a problem hiding this comment.
avoid optional parameter as a public API. Is is necessary>
| } | ||
| } | ||
|
|
||
| public IList<MItem> Items |
There was a problem hiding this comment.
what about using ObservableCollection<MItem> instead?
|
|
||
| namespace Tizen.NET.MaterialComponents | ||
| { | ||
| public class MList : GenList, IColorSchemeComponent |
There was a problem hiding this comment.
As MList inherit GenList, all public APIs of GenList can be exposed. For example, user can use Append() to add item. How do you think about this?
There was a problem hiding this comment.
'MList' thinks it is to provide a 'Material Design', not to constrain its function.
So I think it's a class that makes the 'GenList' look like a 'Material Design', not just a 'Material Design' list.
|
New PR(#52) has been opened according to design changes |
3 participants
Description of Change
This PR is for adding MList
Issues Resolved
API Changes
Added
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
single line
double line
triple line
PR Checklist