Migrate to pyproject.toml and scikit-build-core#6
Conversation
be31a64 to
02d5e99
Compare
e621b0f to
cf21b99
Compare
|
Snippet for testing: cd testsimport tkinter as tk
import tksvg
window = tk.Tk()
svg_image = tksvg.SvgImage(file="orb.svg")
label = tk.Label(image=svg_image)
label.pack()
window.mainloop() |
|
prebuilt wheels: https://github.com/mcha-forks/python-tksvg/actions/runs/8101063696 |
cf21b99 to
fbc9cdb
Compare
|
cc @rdbende @RedFantom any interests in this? |
|
Yup, absolutely, this is amazing! |
|
Should I also make the same change to gttk & tkextrafont? |
|
Actually, that would be awesome. I tried to tackle that multiple times, but always gave up. However that would make the project much more maintainable. |
|
Nice! working on it. :) |
|
The new build system is definitely more straightforward and easier to maintain than the existing appveyor. In addition we will no longer have to backport every upstream change manually, as they are now submodules. Many thanks for this! |
9b3d032 to
5e8154f
Compare
|
Hmm, CI breaks on macos-14-arm64 Filed an issue here: actions/runner-images#9441, will need further investigation edit: applied a workaround by using Homebrew's tcl-tk. Cross-compiling / building fat binaries aren't possible for now. Further tracked at https://feedbackassistant.apple.com/feedback/13673316 |
d9a0b93 to
5e8154f
Compare
5e8154f to
aa75c78
Compare
rdbende
left a comment
There was a problem hiding this comment.
@RedFantom these changes look good to me. Could you take a look at it when you have a little free time?
|
@mochaaP thanks a lot for your work! |
Tested on py3.12/py3.10/py3.8/pypy3.10 Fedora Linux, py3.12 MSVC, py3.12 macOS 10.15
TODO: