Skip to content

Migrate to pyproject.toml and scikit-build-core#6

Merged
rdbende merged 5 commits intoTkinterEP:masterfrom
mcha-forks:migrate-pyproject
Sep 24, 2024
Merged

Migrate to pyproject.toml and scikit-build-core#6
rdbende merged 5 commits intoTkinterEP:masterfrom
mcha-forks:migrate-pyproject

Conversation

@mochaaP
Copy link

@mochaaP mochaaP commented Feb 29, 2024

Tested on py3.12/py3.10/py3.8/pypy3.10 Fedora Linux, py3.12 MSVC, py3.12 macOS 10.15

TODO:

@mochaaP mochaaP force-pushed the migrate-pyproject branch 14 times, most recently from be31a64 to 02d5e99 Compare February 29, 2024 17:41
@mochaaP mochaaP marked this pull request as ready for review February 29, 2024 17:52
@mochaaP mochaaP force-pushed the migrate-pyproject branch 3 times, most recently from e621b0f to cf21b99 Compare February 29, 2024 18:08
@mochaaP
Copy link
Author

mochaaP commented Feb 29, 2024

Snippet for testing:

cd tests
import tkinter as tk
import tksvg

window = tk.Tk()
svg_image = tksvg.SvgImage(file="orb.svg")
label = tk.Label(image=svg_image)
label.pack()
window.mainloop()

@mochaaP
Copy link
Author

mochaaP commented Feb 29, 2024

@mochaaP
Copy link
Author

mochaaP commented Mar 1, 2024

cc @rdbende @RedFantom any interests in this?

@rdbende
Copy link
Member

rdbende commented Mar 1, 2024

Yup, absolutely, this is amazing!
I'll find some time to review it. I'm not sure, when will @RedFantom have time to merge it though

@mochaaP
Copy link
Author

mochaaP commented Mar 1, 2024

Should I also make the same change to gttk & tkextrafont?

@rdbende
Copy link
Member

rdbende commented Mar 1, 2024

Actually, that would be awesome. I tried to tackle that multiple times, but always gave up. However that would make the project much more maintainable.

@mochaaP
Copy link
Author

mochaaP commented Mar 1, 2024

Nice! working on it. :)

Copy link
Member

@rdbende rdbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks/works well for me

@rdbende
Copy link
Member

rdbende commented Mar 2, 2024

The new build system is definitely more straightforward and easier to maintain than the existing appveyor. In addition we will no longer have to backport every upstream change manually, as they are now submodules.

Many thanks for this!

@mochaaP mochaaP force-pushed the migrate-pyproject branch 3 times, most recently from 9b3d032 to 5e8154f Compare March 3, 2024 04:56
@mochaaP
Copy link
Author

mochaaP commented Mar 3, 2024

Hmm, CI breaks on macos-14-arm64 20240219.1 but not 20240116.1 due to a linkage error (target mismatch - needed arm64, presented arm64e)

Filed an issue here: actions/runner-images#9441, will need further investigation

edit: applied a workaround by using Homebrew's tcl-tk. Cross-compiling / building fat binaries aren't possible for now. Further tracked at https://feedbackassistant.apple.com/feedback/13673316

@mochaaP mochaaP force-pushed the migrate-pyproject branch from d9a0b93 to 5e8154f Compare March 4, 2024 16:07
@mochaaP mochaaP force-pushed the migrate-pyproject branch from 5e8154f to aa75c78 Compare March 4, 2024 16:09
@mochaaP
Copy link
Author

mochaaP commented Mar 4, 2024

closes #3
supersedes #1 #4

Copy link
Member

@rdbende rdbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RedFantom these changes look good to me. Could you take a look at it when you have a little free time?

@rdbende rdbende merged commit 8235306 into TkinterEP:master Sep 24, 2024
@rdbende
Copy link
Member

rdbende commented Sep 24, 2024

@mochaaP thanks a lot for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants