-
Notifications
You must be signed in to change notification settings - Fork 32
Improve auto CQ #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve auto CQ #489
Conversation
|
Handle PgUp/Dn (keyer speed up/dn) internally (from #466): make use of |
|
I confirm fldigi grabbing stops autocq with this patch. Thanks! |
these are special terminal-specific keys not known to curses, so had to map them to internal key values. moved Ctrl/Alt-PgUp/Dn handling to handle_common_key()
|
Added handling of Ctrl/Alt-PgUp/Dn (CQ delay control), so #466 is fully covered IMO. Due the specific nature of these key had to restructure key handling a bit: mapping to non-curses keys happens in `onechar()'. |
|
Changing CQ delay has only an immediate effect when shortening it. Lengthening will be effective at the next CQ round. I think this is tolerable. |
|
Changing the keying speed results in CQ delay starting early or late depending on the direction of change. Better yet would be to recalculate the remaining time as soon as the CW speed got changed. |
|
Moved message length calculation into the loop. We have no definite info how much of the message is left when speed changes. It could be possible to estimate it, but it's not worth the effort IMO. For small speed changes (+/- 2 wpm) the difference is hard to notice. |
Thanks. Looks good now.
Yes if first calculation is correct we could estimate based on the percentage of time already spent.
True. It only matters for bigger changes. |
Auto CQ came up in two issues recently (#463 and #466).
Let's see if we can improve here.
Stop auto CQ on callsign grab (from #463): normally the callsign field is empty during CQ, so check if it has been set by a grab (clicking on Fldigi RX window). In addition to key presses consider such events also as CQ-stopper, but don't report them to the caller.