add new code part #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-qote
reviewed
Jun 9, 2024
| } | ||
| } | ||
|
|
||
| void stringCapitalize(TString *s) { |
Tnirpps
requested changes
Jun 9, 2024
Comment on lines
+950
to
+975
| TString stringInitWithCharArr(const char *str) { | ||
| TString s; | ||
| s.length = strlen(str); | ||
| s.capacity = s.length + 1; | ||
| s.data = (char *)malloc(s.capacity * sizeof(char)); | ||
| if (s.data != NULL) { | ||
| strcpy(s.data, str); | ||
| } | ||
| return s; | ||
| } | ||
|
|
||
| void stringDestroy(TString *s) { | ||
| if (s->data != NULL) { | ||
| free(s->data); | ||
| s->data = NULL; | ||
| } | ||
| s->length = 0; | ||
| s->capacity = 0; | ||
| } | ||
|
|
||
| void stringPrint(const TString s) { | ||
| if (s.data != NULL) { | ||
| printf("%s\n", s.data); | ||
| } | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
Но эти функции же уже есть в коде библиотеки
|
|
||
| void stringPrint(const TString s) { | ||
| if (s.data != NULL) { | ||
| printf("%s\n", s.data); |
Owner
There was a problem hiding this comment.
Такой print нельзя, так как буффер строки не заканчивается \0
| s->data[i] = toupper(s->data[i]); | ||
| capitalizeNext = 0; | ||
| } else { | ||
| s->data[i] = tolower(s->data[i]); |
Owner
There was a problem hiding this comment.
Не нужно уменьшать буквы, функция только делает большими первые буквы
Owner
There was a problem hiding this comment.
Readme says: void stringCapitalize(TString *s); - Capitalize the first letter of each word.
|
|
||
| int capitalizeNext = 1; | ||
| for (size_t i = 0; i < s->length; i++) { | ||
| if (isspace(s->data[i])) { |
Owner
There was a problem hiding this comment.
И добавьте знаки пунктуации, которые тоже разделяют слова
| - [x] size_t stringCount(TString s, char c); - Count occurrences of a character. | ||
| - [ ] size_t stringCountSubstring(TString s, TString pattern); - Count occurrences of a substring. | ||
| - [ ] void stringCapitalize(TString *s); - Capitalize the first letter of each word. | ||
| - [x] void stringCapitalize(TString *s); - Capitalize the first letter of each word. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Внес свой вклад в развитие проекта добавлением функции, которая безопасно делает заглавной первую букву каждого слова в строке. Это может быть полезно для форматирования текстовых файлов.