add main.c update csting.h #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tnirpps
requested changes
Jun 7, 2024
Comment on lines
+6
to
+31
| int64_t LevenstheinRecursive(TString s1, TString s2, int64_t len1, int64_t len2) { | ||
| int64_t a, b, c; | ||
| if (len1 == 0) { | ||
| return len2; | ||
| } | ||
| if (len2 == 0) { | ||
| return len1; | ||
| } | ||
| if (s1.data[len1 - 1] == s2.data[len2 - 1]) { | ||
| return LevenstheinRecursive(s1, s2, len1 - 1, len2 - 1); | ||
| } | ||
| a = LevenstheinRecursive(s1, s2, len1 - 1, len2 - 1); | ||
| b = LevenstheinRecursive(s1, s2, len1, len2 - 1); | ||
| c = LevenstheinRecursive(s1, s2, len1 - 1, len2); | ||
|
|
||
| if (a > b) a = b; | ||
| if (a > c) a = c; | ||
| return a + 1; | ||
| } | ||
|
|
||
| int64_t stringLevenstheinDistance(TString s1, TString s2) { | ||
| int64_t len1 = (int64_t)stringLen(s1); | ||
| int64_t len2 = (int64_t)stringLen(s2); | ||
| int64_t res = LevenstheinRecursive(s1, s2, len1, len2); | ||
| return res; | ||
| } |
Owner
There was a problem hiding this comment.
what is it? Place it into cstring.h to other funtions
Comment on lines
+27
to
+29
| int64_t len1 = (int64_t)stringLen(s1); | ||
| int64_t len2 = (int64_t)stringLen(s2); | ||
| int64_t res = LevenstheinRecursive(s1, s2, len1, len2); |
Owner
There was a problem hiding this comment.
Do you really need int64_t? Use size_t instead
Comment on lines
+34
to
+36
| TString myString1 = stringInitWithCharArr("hello world"); | ||
| TString myString2 = stringInitWithCharArr("hello 112312ld"); | ||
| int64_t res = stringLevenstheinDistance(myString1, myString2); |
Owner
There was a problem hiding this comment.
Move test to testfile.
Add more cases: empty string, equal strings and so on
Tnirpps
reviewed
Jun 7, 2024
| #include "cstring.h" | ||
| #include <string.h> | ||
|
|
||
| int64_t LevenstheinRecursive(TString s1, TString s2, int64_t len1, int64_t len2) { |
Tnirpps
requested changes
Jun 7, 2024
| @@ -1,944 +1,945 @@ | |||
| #ifndef CSTRING_LIB | |||
Owner
There was a problem hiding this comment.
This is wrong! The entire file has been deleted and added back, some kind of error. It is necessary that only the really modified parts of the code are highlighted. Please fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in main.c there is a realization of levensthtein distance functrion;
in updated cstring.h there is a new func called stringLevenstheinDistance