implemented stringToDouble feature #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tnirpps
requested changes
May 26, 2024
| int decimalIndex = -1; | ||
| if (s.size > 0 && s.data[0] == '-') { | ||
| sign = -1; | ||
| stringRemove(&s, 0, 1); |
Owner
There was a problem hiding this comment.
Deleting the first element takes O(n), it's too much
It'll be better just set some sort of start_position to 1 and then start loop not from 0 but from start_position
| } | ||
| if (stringCharIsDigit(s.data[i])) { | ||
| result = result * 10.0 + (s.data[i] - '0'); | ||
| } |
Owner
There was a problem hiding this comment.
Else (when it's not a digit) set error like "Not a Number" using setError()
About error handling here
| if (stringCharIsDigit(s.data[i])) { | ||
| result += (s.data[i] - '0') / divisor; | ||
| divisor *= 10.0; | ||
| } |
| TString s1 = stringInitWithCharArr("3.14159"); | ||
| TString s2 = stringInitWithCharArr("123"); | ||
| TString s3 = stringInitWithCharArr("-100"); | ||
|
|
Owner
There was a problem hiding this comment.
Add test with empty string or invalid double -12pas7 8.14
P.S. you forgot to call this test in main()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to add stringToDouble feature that extends the existing functional