Skip to content

Feat/32/login page#71

Merged
ToKyun02 merged 8 commits intomainfrom
feat/32/login-page
Feb 6, 2025
Merged

Feat/32/login page#71
ToKyun02 merged 8 commits intomainfrom
feat/32/login-page

Conversation

@ToKyun02
Copy link
Owner

@ToKyun02 ToKyun02 commented Feb 6, 2025 •
edited
Loading

โ“์ด์Šˆ

โœ๏ธ Description

Modal ์ œ์™ธํ•œ ๋กœ๊ทธ์ธ ํŽ˜์ด์ง€ ๊ธฐ๋Šฅ ๊ตฌํ˜„์— ๊ด€ํ•œ PR์ž…๋‹ˆ๋‹ค.

์ž‘์—… ๋‚ด์šฉ

  • axios request interceptor๋กœ ๋ฆฌํ€˜์ŠคํŠธ ์ „ bearer ํ† ํฐ ์„ค์ • ๋กœ์ง ์ถ”๊ฐ€
  • useAuthStore() ๊ตฌํ˜„
  • login API ํ•จ์ˆ˜ ๊ตฌํ˜„
  • ๋กœ๊ทธ์ธ ์„ฑ๊ณต ํ›„ ํŽ˜์ด์ง€ ์ด๋™์ฒ˜๋ฆฌ(/mydashboard)
  • ํ† ํฐ ์กด์žฌ ์‹œ login, signup ํŽ˜์ด์ง€์—์„œ /mydashboard๋กœ ๋ผ์šฐํŒ… ๋˜๋„๋ก ์ฒ˜๋ฆฌ

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • ํŽ˜์ด์ง€ ๋‹จ์œ„์—์„œ login ์ฒดํฌํ•  ์ˆ˜ ์žˆ๋„๋ก ๋กœ์ง ์ˆ˜์ •(๋กœ๊ทธ์ธ, ํšŒ์›๊ฐ€์ž…ํŽ˜์ด์ง€ ๊ณตํ†ต ๋ ˆ์ด์•„์›ƒ์—์„œ ํ–ˆ๋˜ ๋กœ์ง ๋ถ„๋ฆฌ)

@ToKyun02
โ™ป๏ธ refactor : ๋กœ๊ทธ์ธ ํผ ์Šคํ‚ค๋งˆ, ํƒ€์ž… ๋ถ„๋ฆฌ
e270df8
@ToKyun02
๐Ÿšš chore : auth๊ด€๋ จ components ์ตœ์ƒ์œ„๋กœ ์ด๋™
6f0afbf
@ToKyun02
โœจ login API ํ•จ์ˆ˜ ๊ตฌํ˜„
6e80df1
@ToKyun02
โœจ feat : ๋กœ๊ทธ์ธ ์ƒํƒœ ์ €์žฅ ๊ธฐ๋Šฅ ๊ตฌํ˜„
d776a81 
1. auth store ์ •์˜
2. persist hydration ์˜ค๋ฅ˜ ๋ฐฉ์ง€
3. ๋กœ๊ทธ์ธ ํ›„ /mydashboard๋กœ ๋ผ์šฐํŒ…
@ToKyun02
โœจ feat : ๋กœ๊ทธ์ธ ์„ฑ๊ณต ํ›„ /mydashboard ๋ผ์šฐํŒ… ๊ตฌํ˜„
d905581
@ToKyun02
โ™ป๏ธ refactor : auth store ํ›… ๋ถ„๋ฆฌ ๋ฐ ์š”์ฒญ ์ธํ„ฐ์…‰ํ„ฐ ํ† ํฐ ์„ค์ • ์ถ”๊ฐ€
4ee5355
@ToKyun02
๐Ÿšš chore : ์˜คํƒ€ ์ˆ˜์ •
122451f
@ToKyun02 ToKyun02 added Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Feb 6, 2025
@ToKyun02 ToKyun02 self-assigned this Feb 6, 2025
@vercel
Copy link

vercel bot commented Feb 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 6, 2025 8:50am

@ToKyun02 ToKyun02 requested a review from rak517 February 6, 2025 08:18
Repository owner deleted a comment from ToKyun02 Feb 6, 2025
Repository owner deleted a comment from ToKyun02 Feb 6, 2025
Repository owner deleted a comment from ToKyun02 Feb 6, 2025
rak517
rak517 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@rak517 rak517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ž‘์—… ์—„์ฒญ ๋น ๋ฅด์‹œ๋„ค์š”ใ„ทใ„ท ์ฒ˜์Œ ๋ณด๋Š” ๊ธฐ์ˆ ๋“ค์ด๋ผ ์•„์ง ๋ชจ๋ฅด๋Š”๊ฒŒ ๋งŽ์•„์„œ ์ •ํ™•ํ•œ ๋ฆฌ๋ทฐ๋Š” ํž˜๋“œ๋„ค์š”ใ…œใ…œ ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@ToKyun02 ToKyun02 merged commit 575b97f into main Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rak517 rak517 rak517 approved these changes

Assignees

@ToKyun02 ToKyun02

Labels

Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feat: [ํŽ˜์ด์ง€] ๋กœ๊ทธ์ธ ํŽ˜์ด์ง€ ๊ตฌํ˜„ (๋ชจ๋‹ฌ ์ œ์™ธ)

2 participants

@ToKyun02 @rak517