mirrordaemon: remove dead health peers_known metrics fallback#220
Merged
ToadAid merged 8 commits intoMar 24, 2026
Merged
Conversation
Owner
ToadAid
commented
Mar 24, 2026
ToadAid
commented
- remove the dead metrics.gauges.peers_known fallback from buildHealthSummary
- make health peer truth come only from canonical peer lists passed by callers
- preserve health/status response shape, field names, and current peer counts
- keep scope limited to runtime_state
- verification passed:
- pnpm check
- pnpm vitest run src/mirrordaemon/runtime_state.test.ts src/mirror-service/mirror_service.test.ts
… into fix-mirror-status-runtime-truth
ToadAid
deleted the
mirror/mirrordaemon-drop-dead-health-peers-known-metrics-fallback
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.