observability: inject explicit context into canonical review and commit-scroll seam#231
Merged
ToadAid merged 1 commit intoMar 24, 2026
Conversation
Owner
ToadAid
commented
Mar 24, 2026
- move review observability onto an explicit commitScroll -> reviewDraftForCanon seam
- let reviewDraftForCanon accept a small observability interface instead of relying on process-global helpers directly
- preserve review status derivation, emitted event names, conflict metric names, validation/review ordering, and result shapes
- keep fallback resolution for other direct callers so non-canonical paths continue to work
- verification passed:
- pnpm check
- pnpm vitest run src/mirror-review/review_engine.test.ts src/mirror/skills/commit_scroll/commit_scroll.test.ts src/mirror-observability/observability.test.ts
Owner
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.