Skip to content

observability: inject explicit context into canonical review and commit-scroll seam#231

Merged
ToadAid merged 1 commit into
mainfrom
mirror/observability-remove-remaining-process-global-helper-use-from-canonical-paths
Mar 24, 2026
Merged

observability: inject explicit context into canonical review and commit-scroll seam#231
ToadAid merged 1 commit into
mainfrom
mirror/observability-remove-remaining-process-global-helper-use-from-canonical-paths

Conversation

@ToadAid
Copy link
Copy Markdown
Owner

@ToadAid ToadAid commented Mar 24, 2026

  • move review observability onto an explicit commitScroll -> reviewDraftForCanon seam
  • let reviewDraftForCanon accept a small observability interface instead of relying on process-global helpers directly
  • preserve review status derivation, emitted event names, conflict metric names, validation/review ordering, and result shapes
  • keep fallback resolution for other direct callers so non-canonical paths continue to work
  • verification passed:
    • pnpm check
    • pnpm vitest run src/mirror-review/review_engine.test.ts src/mirror/skills/commit_scroll/commit_scroll.test.ts src/mirror-observability/observability.test.ts

@ToadAid ToadAid merged commit 56f87d7 into main Mar 24, 2026
27 of 28 checks passed
@ToadAid
Copy link
Copy Markdown
Owner Author

ToadAid commented Mar 24, 2026

  • move review observability onto an explicit commitScroll -> reviewDraftForCanon seam
  • let reviewDraftForCanon accept a small observability interface instead of relying on process-global helpers directly
  • preserve review status derivation, emitted event names, conflict metric names, validation/review ordering, and result shapes
  • keep fallback resolution for other direct callers so non-canonical paths continue to work
  • verification passed:
    • pnpm check
    • pnpm vitest run src/mirror-review/review_engine.test.ts src/mirror/skills/commit_scroll/commit_scroll.test.ts src/mirror-observability/observability.test.ts

@ToadAid ToadAid deleted the mirror/observability-remove-remaining-process-global-helper-use-from-canonical-paths branch March 24, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant