Merged
Conversation
eakmanrq
force-pushed
the
eakmanrq/improve_test_perf_parallelize
branch
from
0579eea to
a1f33bb
Compare
eakmanrq
commented
Jan 9, 2024
eakmanrq
force-pushed
the
eakmanrq/improve_test_perf_parallelize
branch
2 times, most recently
from
3a0f043 to
caff61b
Compare
eakmanrq
force-pushed
the
eakmanrq/improve_test_perf_parallelize
branch
from
caff61b to
c62ea6b
Compare
izeigerman
reviewed
Jan 9, 2024
izeigerman
reviewed
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low effort way to improve test performance. Cut times locally in half. Changed Circle from Small to Medium and nearly cut the test time (just test) in half.
Biggest issue now is that we load balance the tests across the workers by module. This is because some module assume we aren't running in parallel and therefore share resources across tests. This results in a skew across the workers. Fix shouldn't be too bad but taking the easy win for now.