Set starting state for editor as empty sql tab #300
Conversation
mykalmax
force-pushed
the
max/editor_start_screen
branch
from
2659ba4 to
45d9e95
Compare
|
testing sql queries doesn't need to be a file, it should just be in memory |
mykalmax
changed the title
it just a new tab in editor without saving. |
mykalmax
force-pushed
the
max/editor_start_screen
branch
from
80e8116 to
17698c1
Compare
mykalmax
force-pushed
the
max/editor_start_screen
branch
from
15bee6d to
98dc883
Compare
web/client/src/models/initial.ts
Outdated
| return this._initial; | ||
| } | ||
|
|
||
| get isModel(): boolean { |
There was a problem hiding this comment.
What does isModel mean? Are there subclasses that override this function and return false?
There was a problem hiding this comment.
it just a flag that signaling this object is a model, does not have to be a getter.
There was a problem hiding this comment.
Got it, but is there a case where isModel is false? How is this flag used?
| return this.files.length > 0; | ||
| } | ||
|
|
||
| get withDirectories(): boolean { |
There was a problem hiding this comment.
i used with for similar cases in other places , so juts for consistency . Or i can rename everywhere
There was a problem hiding this comment.
I think similar to isFoo, hasFoo is more indicative of boolean than withFoo. It's okay for now though.
| return this.directories.length === 0 && this.files.length === 0; | ||
| } | ||
|
|
||
| get withFiles(): boolean { |
| return this.path === ''; | ||
| } | ||
|
|
||
| get withParent(): boolean { |
web/client/src/models/artifact.ts
Outdated
|
|
||
| rename(newName: string): void { | ||
| if (this.isLocal === false) { | ||
| if (this.parent?.isModel) { |
There was a problem hiding this comment.
Use this.hasParent()/this.withParent()
There was a problem hiding this comment.
so even if I guard with this.hasParent()/this.withParent() typescript apparently still think parent can be undefined
| return this.files.length > 0; | ||
| } | ||
|
|
||
| get withDirectories(): boolean { |
There was a problem hiding this comment.
I think similar to isFoo, hasFoo is more indicative of boolean than withFoo. It's okay for now though.
Add Models for File and Directory
Add ability to add empty sql file to test sql queries