-
Notifications
You must be signed in to change notification settings - Fork 313
Random fixes from deploying at customer #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import typing as t | ||
|
|
||
| from sqlglot import exp | ||
|
|
||
| from sqlmesh.core.engine_adapter.base_spark import BaseSparkEngineAdapter | ||
|
|
||
|
|
||
| class BaseDatabricks(BaseSparkEngineAdapter): | ||
| DIALECT = "databricks" | ||
|
|
||
| def create_snapshots_table( | ||
| self, snapshots_table_name: str, snapshots_columns: t.Dict[str, exp.DataType] | ||
| ) -> None: | ||
| """Create a table to store snapshots.""" | ||
| self.create_table( | ||
| snapshots_table_name, | ||
| snapshots_columns, | ||
| partitioned_by=["name", "identifier"], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from sqlmesh.core.engine_adapter.base_databricks import BaseDatabricks | ||
| from sqlmesh.core.engine_adapter.spark import SparkEngineAdapter | ||
|
|
||
|
|
||
| class DatabricksSparkSessionEngineAdapter(SparkEngineAdapter): | ||
| DIALECT = "databricks" | ||
| class DatabricksSparkSessionEngineAdapter(BaseDatabricks, SparkEngineAdapter): | ||
| pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,7 +85,7 @@ def init_schema(self) -> None: | |
| """Creates the schema and table to store state.""" | ||
| self.engine_adapter.create_schema(self.snapshots_table) | ||
|
|
||
| self.engine_adapter.create_table( | ||
| self.engine_adapter.create_snapshots_table( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't the same problem apply to the environments table? Shouldn't we partition it as well? |
||
| self.snapshots_table, self.snapshot_columns_to_types | ||
| ) | ||
| self.engine_adapter.create_table( | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like the fact that the state sync logic leaks into something as low lever as engine adapter