Made changes from feedback #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto max/ui_plan_changes
tobymao
reviewed
Feb 7, 2023
web/client/src/context/plan.ts
Outdated
| } | ||
|
|
||
| type PlanDate = { | ||
| date: Date, |
Contributor
There was a problem hiding this comment.
why do you have all 3? just store the epoch and have methods to display in a format?
tobymao
reviewed
Feb 7, 2023
| id: string | ||
| }) { | ||
| const planState = useStorePlan((s: any) => s.state) | ||
| const planAction = useStorePlan((s: any) => s.action) |
Member
Author
There was a problem hiding this comment.
StorePlan did not have type, but i added it so now need to remove all anys
Member
Author
There was a problem hiding this comment.
I need to fix type for StorePlan in few places , better have as separate PR
tobymao
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not include fixing project structure navigation issues (add/create/delete)