Introduce a workaround for a race condition that happens during SQLMesh schema creation in the Airflow plugin #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izeigerman
requested review from
crericha,
eakmanrq,
georgesittas,
tobymao and
vchan
tobymao
reviewed
Feb 8, 2023
sqlmesh/schedulers/airflow/plugin.py
Outdated
Contributor
There was a problem hiding this comment.
should we try a couple times?
Member
Author
There was a problem hiding this comment.
Not really. If a transaction fails because of this reason, it means that the other concurrent transaction succeeds and the schema gets created. Next time we retry, the IF NOT EXISTS check will work correctly. My current understanding is that one retry should be enough at all times.
tobymao
approved these changes
Feb 8, 2023
…sh schema creation in the Airflow plugin
izeigerman
force-pushed
the
workaround-create-schema-race-condition
branch
from
74d80db to
e1e8dd5
Compare
georgesittas
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.