Change type for useStorePlan #334
Conversation
There was a problem hiding this comment.
why is there so much boiler plate here? is there a library we could use for what you're trying to do?
There was a problem hiding this comment.
same here, what's all this boiler plate
cc @vchan
There was a problem hiding this comment.
We have an object which keeps track of state in the app. All this boilerplate code pulls fields out of the state object that this component needs. The reason we don't just have const state = useStorePlan() and use state.plan or state.environment everywhere is because it might trigger unnecessary re-renders when something else in the state that this component doesn't care about changes.
There was a problem hiding this comment.
we are using library for shared state , here is example from their docs https://github.com/pmndrs/zustand/blob/main/docs/guides/slices-pattern.md#usage-in-a-react-component
So another problem is that component is big and need some refactoring and splitting into smaller chunks. it will reduce number of state a bit
There was a problem hiding this comment.
Want to confirm it should be model_name and not modelName.
There was a problem hiding this comment.
we are getting that value from API (type ContextEnvironmentBackfill) and using as is
There was a problem hiding this comment.
Should category have a type here? Category?
There was a problem hiding this comment.
it is inferred from client.ts
There was a problem hiding this comment.
it is inferred from client.ts
mykalmax
force-pushed
the
max/ui_fix_type_for_planStore
branch
from
c93ca8b to
cda54c5
Compare
No description provided.