Skip to content

Exclude python code from the rendered definition of SQL models when using magics #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

Exclude python code from the rendered definition of SQL models when using magics #350

merged 1 commit into from
Feb 10, 2023

Conversation

@izeigerman
Copy link
Member

@izeigerman izeigerman commented Feb 10, 2023

Fixes #345

@izeigerman izeigerman force-pushed the exclude-python-when-rendering-sql-model-in-magics branch from 94a60b7 to bc448a6 Compare February 10, 2023 19:02
eakmanrq
eakmanrq approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@eakmanrq eakmanrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@izeigerman izeigerman merged commit a4e6194 into main Feb 10, 2023
@izeigerman izeigerman deleted the exclude-python-when-rendering-sql-model-in-magics branch February 10, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eakmanrq eakmanrq eakmanrq approved these changes

@vchan vchan Awaiting requested review from vchan

@tobymao tobymao Awaiting requested review from tobymao

@georgesittas georgesittas Awaiting requested review from georgesittas

@crericha crericha Awaiting requested review from crericha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

%model magic adds Macro definition to SQL

3 participants

@izeigerman @eakmanrq