Fix file not getting save after a change (not sending api request) #351
Conversation
|
|
||
| setEditorFileStatus(EnumEditorFileStatus.Saving) | ||
|
|
||
| if (activeFile?.isLocal || activeFile.content === value) return setIsSaved(true) |
There was a problem hiding this comment.
What's the return value of setIsSaved()?
| <small>File Status: {fileStatus}</small> | ||
| <small>{getLanguageByExtension(activeFile?.extension)}</small> | ||
| <div className='flex align-center mr-4'> | ||
| <Indicator text="Valid" ok={isSaved} /> |
There was a problem hiding this comment.
Why is Valid tied to whether the file is saved or not? If it's a placeholder, can you just set it to true?
| )} | ||
|
|
||
| {!activeFile?.isLocal && ( | ||
| {activeFile?.isLocal === false && ( |
There was a problem hiding this comment.
why do you need to check isLocal? is it because activeFile? could be null?
There was a problem hiding this comment.
activeFile in editor can be either from file system (where we need to read content of that file) or created by clicking on plus button to add empty in-memory sql file to send queries, so isLocal just indicates that
There was a problem hiding this comment.
sorry my question is why not just check isLocal which is boolean, why do you === false
There was a problem hiding this comment.
actually here activeFile should not be 'null'.
always missing that ! so === more explicit
Fix bug and added indication when file saved.
