Chore: Address Clickhouse Cloud test flakiness#3782
Merged
Conversation
erindru
commented
Feb 4, 2025
.circleci/continue_config.yml
Outdated
| #filters: | ||
| # branches: | ||
| # only: | ||
| # - main |
Collaborator
Author
There was a problem hiding this comment.
TODO: reinstate prior to merge
erindru
force-pushed
the
erin/fix-clickhouse-cloud
branch
from
b0c3a3b to
454cef9
Compare
erindru
changed the title
tobymao
approved these changes
Feb 4, 2025
treysp
approved these changes
Feb 4, 2025
georgesittas
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to debug the following issue noticed in the failing clickhouse cloud tests on main:
It looks like Clickhouse Cloud can now go into an
idlestate. I added a pre-ping to ensure the cicd instance is running before triggering the tests.However, the issue still occurred. So I set:
on the connection config (previously it was using the default value of 10).
This actually did fix the connection issue but it raised another issue:
So it looks like Clickhouse Cloud is now limiting the number of "databases" (schemas) that you can have on a single instance. I cleared out a bunch of test schemas left over from failed runs and now the tests can run successfully again.
After this, I still experienced some flakiness. I reduced the pytest concurrency to 1 and increased the number of HTTP retries on the Clickhouse connection pool. I also removed the
-xoption because I notice it conflicts withpytest-retryand results inpytest-retrynot retrying tests (this is a problem for the other engine adapter integration tests too, however that can be addressed in a different PR)