Add rename functionality for files and directories #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
reviewed
Feb 17, 2023
Contributor
There was a problem hiding this comment.
if new_path != path, if new_path is none, this just won't work right
Contributor
Author
There was a problem hiding this comment.
If new_path is None, I want to skip this block
Contributor
There was a problem hiding this comment.
isn't it the same new-path and new_path != path is the same is new_path != path because path is not None
Contributor
Author
There was a problem hiding this comment.
Ah, I see what you mean. I want the following block to run (it moves a file) if new_path != path, except if new_path is None. If new_path is None, then there's nowhere to move the file.
tobymao
reviewed
Feb 17, 2023
web/server/api/endpoints/files.py
Outdated
Contributor
There was a problem hiding this comment.
seems like you could dry this up
vchan
force-pushed
the
vchan/api-rename-files
branch
from
53de7d6 to
f513315
Compare
tobymao
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.