first pass sql model #397
Merged
first pass sql model #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eakmanrq
reviewed
Feb 18, 2023
eakmanrq
reviewed
Feb 18, 2023
eakmanrq
reviewed
Feb 18, 2023
eakmanrq
reviewed
Feb 18, 2023
docs/concepts/models/sql_models.md
Outdated
| ON employees.id = countries.employee_id | ||
| ``` | ||
|
|
||
| SQLMesh will detect that the model depends on both employees and countries. When evaluating this model, it will ensure that employees and countries will be evaluated first. External dependencies that are not defined in SQLMesh are also supported. SQLMesh can either depend on them via a schedule or through signals if you are using [Airflow](../../../integrations/airflow). |
Contributor
There was a problem hiding this comment.
What did you mean here by depend on them via a schedule? Also we haven't really implemented the ability to depend on an external model via. signal in Airflow.
eakmanrq
reviewed
Feb 18, 2023
docs/concepts/models/sql_models.md
Outdated
| Additionally you don't have to worry about things like trailing commas as SQLGlot will remove them at parse time. | ||
|
|
||
| ## Macros | ||
| Although SQL is very powerful, it is often required to run SQL queries with dynamic components like date filters. Additionally, large queries can be difficult to read and maintain, so having macros is powerful tool to address these advanced use cases. |
Contributor
There was a problem hiding this comment.
Although SQL is very powerful, it is often required to run SQL queries with dynamic components like date filters.. I think there is a missing sentence after this. You are referencing variables here but then don't explain what a variable is.
eakmanrq
approved these changes
Feb 18, 2023
Co-authored-by: Ryan Eakman <6326532+eakmanrq@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.