Skip to content

Conversation

@VaggelisD
Copy link
Contributor

@VaggelisD VaggelisD commented Mar 25, 2025

This PR enhances the CI/CD bot with a new check specific to the linter.

For the new check, we have the following cases:

  • If linting is disabled, the check does not run at all

  • If linting is fully successful, the check passes with Linter Success

  • If linting shows error/warning outputs, the summary is as shown below:

  • Linter errors

linter_errors

  • Linter warnings
linter_warnings

@VaggelisD VaggelisD requested a review from a team March 25, 2025 16:07
Copy link
Contributor

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable, although I'm not super familiar with the CICD bot's code in general. Left a few questions to understand things a bit better.

@VaggelisD VaggelisD force-pushed the vaggelisd/cicdbot_linter branch from b8773f4 to 8f2b7ee Compare March 25, 2025 17:59
@VaggelisD
Copy link
Contributor Author

VaggelisD commented Mar 25, 2025

Note: #4032 actually solves the initial problem.

This PR should now be rebased on top of it & divert the output to the new linter check/job.

@VaggelisD VaggelisD marked this pull request as draft March 26, 2025 14:10
@VaggelisD VaggelisD force-pushed the vaggelisd/cicdbot_linter branch 4 times, most recently from ba0b56d to 7e6eba6 Compare March 28, 2025 21:46
@VaggelisD VaggelisD marked this pull request as ready for review March 28, 2025 21:58
@VaggelisD VaggelisD force-pushed the vaggelisd/cicdbot_linter branch from 7e6eba6 to 2cf6f51 Compare March 28, 2025 22:03
Copy link
Contributor

@eakmanrq eakmanrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update docs to document the new linter bot output and put a screenshot of the linter output from this PR in the examples sections so users can see that this functionality is included.

@VaggelisD VaggelisD requested a review from a team March 31, 2025 15:37
@VaggelisD VaggelisD merged commit c0cf0af into main Mar 31, 2025
22 checks passed
@VaggelisD VaggelisD deleted the vaggelisd/cicdbot_linter branch March 31, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants