-
Notifications
You must be signed in to change notification settings - Fork 327
Feat: Add CICD bot check for linting #4027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look reasonable, although I'm not super familiar with the CICD bot's code in general. Left a few questions to understand things a bit better.
b8773f4 to
8f2b7ee
Compare
|
Note: #4032 actually solves the initial problem. This PR should now be rebased on top of it & divert the output to the new linter check/job. |
ba0b56d to
7e6eba6
Compare
7e6eba6 to
2cf6f51
Compare
eakmanrq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update docs to document the new linter bot output and put a screenshot of the linter output from this PR in the examples sections so users can see that this functionality is included.
This PR enhances the CI/CD bot with a new check specific to the linter.
For the new check, we have the following cases:
If linting is disabled, the check does not run at all
If linting is fully successful, the check passes with
Linter SuccessIf linting shows error/warning outputs, the summary is as shown below:
Linter errors