Skip to content

Conversation

@benfdking
Copy link
Contributor

  • little improvements to the removing and labelling of sessions

- little improvements to the removing and labelling of sessions
@benfdking benfdking requested a review from Copilot April 19, 2025 18:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new device sign-in flow to the VS Code extension along with slight improvements to session management and labelling.

  • Added a utility (isCodespaces) to detect Codespaces environments.
  • Integrated a new command ("sqlmesh.signinSpecifyFlow") and its corresponding authentication flow.
  • Enhanced the authentication provider to support both OAuth and device flow sign-ins.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vscode/extension/src/utilities/isCodespaces.ts Added a helper function to check for Codespaces environment.
vscode/extension/src/extension.ts Integrated the new signInSpecifyFlow command.
vscode/extension/src/commands/signinSpecifyFlow.ts Added a command to allow users to select their sign-in flow.
vscode/extension/src/commands/signin.ts Updated signIn logic to branch based on environment.
vscode/extension/src/auth/auth.ts Extended authentication functionality to include device flow.
Files not reviewed (1)
  • vscode/extension/package.json: Language not supported

@benfdking benfdking merged commit beb24f0 into main Apr 20, 2025
22 checks passed
@benfdking benfdking deleted the adding_vscode_auth_provider_device_flow branch April 20, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants