Skip to content

Add getEntityId method to EntityMeta#56

Merged
Tofaa2 merged 1 commit into
Tofaa2:masterfrom
3add:feat/fix-entity-entityid
May 13, 2026
Merged

Add getEntityId method to EntityMeta#56
Tofaa2 merged 1 commit into
Tofaa2:masterfrom
3add:feat/fix-entity-entityid

Conversation

@3add
Copy link
Copy Markdown
Contributor

@3add 3add commented May 12, 2026

Fixes #55

Summary by CodeRabbit

  • New Features
    • Added a new public accessor method to retrieve entity identifiers, improving API flexibility and access to entity metadata.

Review Change Stack

Copilot AI review requested due to automatic review settings May 12, 2026 14:44
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5443ff35-f5d2-413c-9c9a-ea80d1e178ef

📥 Commits

Reviewing files that changed from the base of the PR and between 87ec596 and e4a1b93.

📒 Files selected for processing (1)
  • api/src/main/java/me/tofaa/entitylib/meta/EntityMeta.java

📝 Walkthrough

Walkthrough

The PR adds a public getEntityId() accessor method to the EntityMeta class, exposing the previously inaccessible entityId field. This simple getter returns an integer entity identifier.

Changes

Entity ID Accessor

Layer / File(s) Summary
Entity ID getter method
api/src/main/java/me/tofaa/entitylib/meta/EntityMeta.java
A new public getEntityId() method is added that returns the entityId field, allowing external code to retrieve the entity identifier.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A getter so simple, so clean and so neat,
Just four little lines make the change complete.
EntityId hops out for the world now to see,
A tiny accessor, as helpful can be!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a getEntityId method to EntityMeta, which matches the code changes.
Linked Issues check ✅ Passed The pull request fulfills the linked issue #55 requirement by adding the missing getEntityId() method to EntityMeta class as requested.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue; only the getEntityId() method was added with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a missing accessor on EntityMeta to expose the owning entity’s numeric ID, addressing Issue #55 and aligning EntityMeta with other API surfaces that already expose an entity id.

Changes:

  • Added EntityMeta#getEntityId() returning the stored entityId.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tofaa2 Tofaa2 merged commit e4a1b93 into Tofaa2:master May 13, 2026
5 of 6 checks passed
@Tofaa2
Copy link
Copy Markdown
Owner

Tofaa2 commented May 13, 2026

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EntityMeta.java misses #getEntityId()

3 participants