fix: AI message dismiss button #1403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when message that created thread was deleted, retrieveStartMessage() threw an error UNKNOWN_MESSAGE leading to non-functional dismiss button. this adds a handler, specifically for parent message deleted error by using getIterableHistoryInstead.
tj-wazei
requested changes
Feb 1, 2026
| .build(); | ||
| private final ComponentIdInteractor componentIdInteractor = | ||
| new ComponentIdInteractor(getInteractionType(), getName()); | ||
| private static final int FIRST_MESSAGE_ONLY = 1; |
Contributor
There was a problem hiding this comment.
The naming is a bit off and perhaps something you would give to a boolean. Instead, let's rename this to NUMBER_OF_MESSAGES + some additional context.
| ThreadChannel channel = event.getChannel().asThreadChannel(); | ||
| Member interactionUser = Objects.requireNonNull(event.getMember()); | ||
|
|
||
| Consumer<Throwable> handleParentMessageDeleted = error -> { |
Contributor
There was a problem hiding this comment.
You can extract this as it's own function as opposed to defining it like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when message that created thread was deleted,
retrieveStartMessage() threw an error UNKNOWN_MESSAGE leading to non-functional dismiss button.
this adds a handler, specifically for parent message deleted error by using getIterableHistoryInstead.
resolves #1400