feat: add activated field to modules metadata#439
Conversation
WalkthroughThis pull request updates several validation schemas in the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/validations/module.validation.ts (1)
49-172: Consider setting a default value for theactivatedfield.All the added
activatedfields are optional without default values. Consider adding a default value (e.g.,Joi.boolean().default(true)) to ensure consistent behavior when the field is not explicitly provided.🧰 Tools
🪛 Biome (1.9.4)
[error] 100-100: Do not add then to an object.
(lint/suspicious/noThenProperty)
[error] 104-104: Do not add then to an object.
(lint/suspicious/noThenProperty)
[error] 108-108: Do not add then to an object.
(lint/suspicious/noThenProperty)
[error] 112-112: Do not add then to an object.
(lint/suspicious/noThenProperty)
[error] 116-116: Do not add then to an object.
(lint/suspicious/noThenProperty)
[error] 120-120: Do not add then to an object.
(lint/suspicious/noThenProperty)
[error] 152-152: Do not add then to an object.
(lint/suspicious/noThenProperty)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/validations/module.validation.ts(6 hunks)
🔇 Additional comments (8)
src/validations/module.validation.ts (8)
4-4: LGTM: Clean up of import statement.The import statement has been consolidated into a single line, which improves code readability.
49-49: Addedactivatedfield for consistency.The addition of the
activatedboolean field to the hivemindDiscordMetadata schema allows tracking of activation status for Discord modules.
58-58: Addedactivatedfield for consistency.The addition of the
activatedboolean field to the hivemindGoogleMetadata schema allows tracking of activation status for Google modules.
72-72: Addedactivatedfield for consistency.The addition of the
activatedboolean field to the hivemindNotionMetadata schema allows tracking of activation status for Notion modules.
79-79: Addedactivatedfield for consistency.The addition of the
activatedboolean field to the hivemindMediaWikiMetadata schema allows tracking of activation status for MediaWiki modules.
84-86: Updated websiteMediaWikiMetadata to includeactivatedfield.The websiteMediaWikiMetadata function now returns an object with the
activatedboolean field instead of an empty object, maintaining consistency with other metadata schemas.
136-136: Addedactivatedfield for consistency.The addition of the
activatedboolean field to the violationDetectionMetadata schema allows tracking of activation status for violation detection modules.
172-172: Addedactivatedfield for consistency.The addition of the
activatedboolean field to the dynamicNftOptions metadata schema allows tracking of activation status for dynamic NFT modules.
1 participant
Summary by CodeRabbit