test: Add autotest for group moderation #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
changed the title
auto-add-label
bot
added
the
test
Codecov Report
@@ Coverage Diff @@
## ngc #1519 +/- ##
==========================================
+ Coverage 79.30% 81.67% +2.36%
==========================================
Files 94 95 +1
Lines 20223 20366 +143
==========================================
+ Hits 16038 16634 +596
+ Misses 4185 3732 -453
Continue to review full report at Codecov.
|
iphydf
requested changes
May 6, 2020
auto_tests/group_message_test.c
Outdated
|
|
||
| printf("%s sent message to %s: %s\n", peer_name, self_name, message_buf); | ||
| ck_assert(memcmp(message_buf, TEST_MESSAGE, length) == 0); | ||
| ck_assert(!memcmp(message_buf, TEST_MESSAGE, length)); |
Member
There was a problem hiding this comment.
Prefer == 0, because int is not an Essentially Boolean type (MISRA C:2012 8.10.2). I know !memcmp and !strcmp is a common idiom in C, but prefer strong typing over poor (even if common) idioms.
Fixed a couple issues in the other group tests as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a small bug in group_message_test as well
This change is