Skip to content

refactor: UI / UX 体验优化#16

Merged
zhxycn merged 12 commits into
mainfrom
refactor/ui
May 20, 2026
Merged

refactor: UI / UX 体验优化#16
zhxycn merged 12 commits into
mainfrom
refactor/ui

Conversation

@zhxycn
Copy link
Copy Markdown
Member

@zhxycn zhxycn commented May 20, 2026

No description provided.

@zhxycn zhxycn self-assigned this May 20, 2026
@zhxycn zhxycn added bug Something isn't working enhancement New feature or request labels May 20, 2026
@zhxycn zhxycn marked this pull request as ready for review May 20, 2026 11:52
@zhxycn zhxycn marked this pull request as draft May 20, 2026 11:54
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65061f1525

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread components/layout/schedule.tsx Outdated
@zhxycn zhxycn marked this pull request as ready for review May 20, 2026 12:10
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15b2eda592

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

import { useColorScheme } from "@/hooks/use-color-scheme";
import { useT } from "@/lib/i18n";

const HEADER_HEIGHT = 40;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Match drawer top offset to actual header height

CourseDrawer anchors both the blur overlay and the panel at insets.top + 40, but the course screen header it is supposed to sit below is h-12 (48px) in app/(tabs)/course.tsx. This 8px mismatch makes the drawer/overlay start inside the header region, so the lower part of the header can be visually covered and receive blocked touches when the drawer is open, contradicting the component’s own “do not affect top controls” behavior.

Useful? React with 👍 / 👎.

@zhxycn zhxycn merged commit 788cd13 into main May 20, 2026
1 check passed
@zhxycn zhxycn deleted the refactor/ui branch May 20, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant