feat: generalize Docker services#1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the Redis-specific Docker path with a generic
dockerServicesconfiguration model. Redis is now just another declared Docker service, and legacytype: "redis"env patches are removed as a breaking change.What changed
wt.config.json.wt-<slot>-<repo>-<hash>.managed-redismodule and Redis patch type.dist.wt-locallocal build wiring and bumped the breaking-change version to0.4.0.Impact
Configs using
type: "redis"must switch totype: "url"forREDIS_URLand declare Redis underdockerServices. Electric and Redis can now both live inwt.config.jsoninstead of a checked-in Docker Compose file.Validation
pnpm lintpnpm buildpnpm test --runInBandpnpm test:docker~/sources/tokenbookswith Redis and Electric in slot 22