Server Event Refactors #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moves MenuToggle keymapping from constructor to PostPermissions function since the menu might not exist when the constructor runs
Vayyni
approved these changes
Oct 19, 2025
Collaborator
Vayyni
left a comment
Vayyni
left a comment
There was a problem hiding this comment.
After reviewing everything last night, the end result appears to be good state and fully functional. I see no issues as per our conversations in private channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR refactors all the server-side events; it primarily brings all the permissions checking up-to-date, but also hardens some events to prevent exploits, and replaces older client-side methods with newer server-side ones.