Added the ability to close file handles#1
Merged
TomOnTime merged 7 commits intoTomOnTime:masterfrom May 11, 2018
Merged
Conversation
Still need to implement ScanCloser and uncomment NewScanner().
TomOnTime
reviewed
May 10, 2018
utfutil.go
Outdated
| scanner *bufio.Scanner | ||
| } | ||
|
|
||
| // Buffer will run the Buffer functoin on the underlying bufio.Scanner. |
TomOnTime
reviewed
May 10, 2018
README.md
Outdated
|
|
||
| Utilities to make it easier to read text encoded as UTF-16. | ||
|
|
||
| ## Forked |
Owner
There was a problem hiding this comment.
This should be removed when we merge.
Owner
|
Wow! I had no idea anyone was using this module besides me. I'm super excited to accept this PR. I had a few cosmetic suggestions. |
Rename `functoin` to `function`. Remove forked comment from readme.
Contributor
Author
|
@TomOnTime Yes, this module has been a life saver! Thanks so much for making it! :) |
Owner
|
Thanks for the PR! You really cleaned up my mess! ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the ability to close file handles via new
ReadCloserandScanCloserinterfaces.