Skip to content

Pr 179 fixes#1

Merged
TomV76 merged 2 commits into
TomV76:STL-gain-check-toolfrom
ludomal:pr-179-fixes
May 29, 2026
Merged

Pr 179 fixes#1
TomV76 merged 2 commits into
TomV76:STL-gain-check-toolfrom
ludomal:pr-179-fixes

Conversation

@ludomal
Copy link
Copy Markdown

@ludomal ludomal commented May 29, 2026

Thanks for the great tool contribution.

Here is a PR with proposed changes for your consideration.

CTest fails on MacOS (and most likely Linux) because of CRLF line endings in the reference files. I assume they have been generated on Windows. The fix is to let Git update the reference file automatically according to the platform it checks out (see .gitattributes).

I have also updated the documentation with more details on the output file and usage to match the other sections of the manual, added links and moved the section just after freqresp.

Ludovic Malfait added 2 commits May 29, 2026 10:55
Add .gitattributes with eol=native for .ref files so they are checked
out with platform-native line endings, matching gain_chk stderr output.
Normalize stored ref files to LF.
- Move chapter after freqresp (spectral analysis tools grouped together)
- Add labels to chapter and all sections for cross-referencing
- Add output file format subsection describing -t results structure
- Add usage examples with sample output and threshold check
- Fix data format description (remove incorrect endianness wording)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants