Content Browser branch refactor

[Nickelony]

No description provided.

[Copilot]

Pull request overview

Refactors parts of TombEditor’s WPF UI (Content Browser, ToolBox, Object Brush Toolbox) toward an MVVM + localization-driven approach, reducing code-behind event wiring and moving UI text into localization resources.

Changes:

• Added EN localization entries for Content Browser and toolbox-related views.
• Reworked ToolBoxView and ObjectBrushToolboxView to bind to new MVVM view models and use XAML-based icons/resources.
• Updated Content Browser view/controller plumbing (commands, drag-drop routing, visual-tree helpers, localized item count text).

Reviewed changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
TombLib/TombLib.WPF/Resources/Localization/EN/TombEditor.json	Adds localized strings for Content Browser + toolboxes.
TombEditor/Views/ToolBoxView.xaml.cs	Moves tool state handling to ToolBoxViewModel; keeps layout measurement + WinForms context menu hosting.
TombEditor/Views/ToolBoxView.xaml	Converts toolbox UI to command/binding-driven XAML with localized tooltips and PNG resources.
TombEditor/Views/ObjectBrushToolboxView.xaml.cs	Switches to MVVM DataContext + cleanup hook.
TombEditor/Views/ObjectBrushToolboxView.xaml	Converts object brush controls to bindings; localizes labels.
TombEditor/Views/ContentBrowserView.xaml.cs	Uses DarkUI visual ancestor helper; routes file drop to VM instead of exposing a view event.
TombEditor/Views/ContentBrowserView.xaml	Adds watermark service + localized placeholder/labels; binds item count via localized VM property; command-based interactions.
TombEditor/ViewModels/ToolBoxViewModel.cs	New VM handling tool checked state, mode visibility, grid paint tooltip/icon, and commands.
TombEditor/ViewModels/ObjectBrushToolboxViewModel.cs	New VM for object-brush settings + enabled-state logic derived from editor/tool state.
TombEditor/ViewModels/ContentBrowserViewModel.cs	Adds localization service usage and localized formatting; minor refactor/cleanup of models and filtering.
TombEditor/ToolWindows/ContentBrowser.cs	Routes dropped files via VM event; retains thumbnail rendering, selection sync, and editor integration.
TombEditor/TombEditor.csproj	Includes PNGs as WPF resources for XAML-pack URI icon usage.
TombEditor/Controls/ToolBox.Designer.cs	Removes explicit Cleanup call in Dispose.
TombEditor/Controls/ObjectBrush/ObjectBrushToolbox.Designer.cs	Removes explicit Cleanup call in Dispose.

Files not reviewed (2)

• TombEditor/Controls/ObjectBrush/ObjectBrushToolbox.Designer.cs: Language not supported
• TombEditor/Controls/ToolBox.Designer.cs: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Nickelony]

@copilot Could you please verify that this refactor doesn't break any existing functionality of the target branch?

[Copilot]

@Nickelony I've opened a new pull request, #1148, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.

Files not reviewed (2)

• TombEditor/Controls/ObjectBrush/ObjectBrushToolbox.Designer.cs: Language not supported
• TombEditor/Controls/ToolBox.Designer.cs: Language not supported

Comments suppressed due to low confidence (2)

TombEditor/Views/ContentBrowserView.xaml.cs:85

• FindVisualAncestor<T>() doesn’t include the starting element itself. If e.OriginalSource happens to be a ListBoxItem, container will be null and the double-click animation may not play. Consider handling the self case (e.g., source as ListBoxItem ?? source.FindVisualAncestor<ListBoxItem>()).

			if (e.OriginalSource is DependencyObject source)
			{
				var container = source.FindVisualAncestor<ListBoxItem>();

				if (container is not null)
					PlayAddItemAnimation(container);
			}

TombEditor/Views/ContentBrowserView.xaml.cs:196

• hitContainer lookup has the same self-skip behavior: when OriginalSource is the ListBoxItem, FindVisualAncestor<ListBoxItem>() returns its parent and the click/drag logic can misclassify the target as empty space. Consider falling back to (source as ListBoxItem) before walking ancestors.

		var hitContainer = (e.OriginalSource as DependencyObject)?.FindVisualAncestor<ListBoxItem>();

		if (hitContainer?.DataContext is AssetItemViewModel hitItem &&
			AssetListBox.SelectedItems.Contains(hitItem) &&
			AssetListBox.SelectedItems.Count > 1 &&
			!Keyboard.Modifiers.HasFlag(ModifierKeys.Control) &&
			!Keyboard.Modifiers.HasFlag(ModifierKeys.Shift))
		{
			// Prevent the ListBox from deselecting the multi-selection on mouse-down.
			// If the user just clicks (no drag), we deselect in PreviewMouseLeftButtonUp.
			_clickedOnSelected = true;
			_clickedItem = hitItem;
			e.Handled = true;
		}
		else if (hitContainer is null && !Keyboard.Modifiers.HasFlag(ModifierKeys.Alt))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.

Files not reviewed (2)

• TombEditor/Controls/ObjectBrush/ObjectBrushToolbox.Designer.cs: Language not supported
• TombEditor/Controls/ToolBox.Designer.cs: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.

Files not reviewed (2)

• TombEditor/Controls/ObjectBrush/ObjectBrushToolbox.Designer.cs: Language not supported
• TombEditor/Controls/ToolBox.Designer.cs: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.