Skip to content

Refine flyby timeline startup, selection sync, layout separation, and FOV bounds#1192

Open
Copilot wants to merge 4 commits into
developfrom
copilot/improve-timeline-control
Open

Refine flyby timeline startup, selection sync, layout separation, and FOV bounds#1192
Copilot wants to merge 4 commits into
developfrom
copilot/improve-timeline-control

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 19, 2026 •
edited
Loading

  • Review the new PR comments and inspect the affected flyby timeline files
  • Check recent branch history and current validation constraints in this environment
  • Replace the non-XML helper comment with XML documentation and make FOV degree/radian naming explicit
  • Centralize flyby FOV clamping so lower and upper bounds are handled consistently across preview and editor paths
  • Remove any now-unused selection helper code if it is no longer referenced
  • Run automated review/security validation with parallel_validation
  • Attempt targeted local validation (dotnet test TombEditor.Tests/TombEditor.Tests.csproj -c Release -p:EnableWindowsTargeting=true --filter FlybyPreviewTests) and confirm it is still blocked in this Linux environment by missing Windows SDK shader compiler fxc.exe
  • Reply to each actionable review comment with the addressing commit hash

Copilot AI linked an issue Apr 19, 2026 that may be closed by this pull request
TE: Timeline control improvements #1182
Open
4 tasks
Copilot AI and others added 2 commits April 19, 2026 19:48
Copilot AI changed the title [WIP] Fix ghost timeline animation and improve controls Refine flyby timeline startup, selection sync, layout separation, and FOV bounds Apr 19, 2026
Copilot AI requested a review from Nickelony April 19, 2026 19:53
Nickelony
Nickelony requested changes Apr 19, 2026
View reviewed changes
Comment thread TombEditor/Controls/FlybyTimeline/Preview/FlybyPreview.cs Outdated
Comment thread TombEditor/Controls/FlybyTimeline/Preview/FlybyFrameState.cs
Comment thread TombEditor/Controls/FlybyTimeline/ViewModel/FlybyTimelineViewModel.Properties.cs Outdated
Comment thread TombEditor/Controls/FlybyTimeline/ViewModel/FlybyTimelineViewModel.Selection.cs
Comment thread TombEditor/Controls/FlybyTimeline/FlybyConstants.cs Outdated
@Nickelony Nickelony marked this pull request as ready for review April 19, 2026 20:08
@Nickelony
fix: address flyby FOV review feedback
daa3787 
Agent-Logs-Url: https://github.com/TombEngine/Tomb-Editor/sessions/913d7b38-6fb6-4386-83bd-eb8c7a9c8695

Co-authored-by: Nickelony <20436882+Nickelony@users.noreply.github.com>
Copilot AI requested a review from Nickelony April 19, 2026 20:12
@Nickelony Nickelony added ready for review The Pull Request is finished and ready for review. bug Something isn't working as intended. enhancement A task which adds something new or improves on existing features. labels Apr 19, 2026
@Nickelony Nickelony added this to the Version 2.0 milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nickelony Nickelony Awaiting requested review from Nickelony

Requested changes must be addressed to merge this pull request.

Assignees

@Nickelony Nickelony

Copilot code review Copilot

Labels

bug Something isn't working as intended. enhancement A task which adds something new or improves on existing features. ready for review The Pull Request is finished and ready for review.

Projects

None yet

Milestone

Version 2.0

Development

Successfully merging this pull request may close these issues.

TE: Timeline control improvements

2 participants

@Nickelony