Make dxchange and olefile optional requirements#2209
Conversation
There was a problem hiding this comment.
- you'd have to add olefile to run_constrained
- you'd have to add zenodo_get, olefile, dxchange, ipywidgets, etc to the README table's "optional deps" rows
- you'd be violating conda's lack of first-class support of trivial optional deps
conda install pkgwas designed to be equivalent topip install pkg[all]- alternatively could have a separate package
conda install cil-base(similar tomatplotlib-baseapproach)
|
reopening for future discussion |
|
As long as these are in the environment files I think we're good to merge. Maybe in the table we can add CT data reader dependancies as a sub section as this is where most of our small packages come in and won't be universally needed or wanted. |
Hi @gfardell, yes dxchange and olefile are in the cil_demos, cil_demos_cpu and cil_test environment files. zenodo_get isn't in them but I will add them now. I've added olefile and dxchange to the dependency table in the README. As discussed I also moved the installation with the env files to the top of the installation instructions section and added a note on how to rename the environment and activate it. |
Signed-off-by: Hannah Robarts <77114597+hrobarts@users.noreply.github.com>
Signed-off-by: Hannah Robarts <77114597+hrobarts@users.noreply.github.com>
Changes
Testing you performed
Related issues/links
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.