test: unit tests for hook handlers (GIT-57)

[TonyCasey]

Summary

• Add non-Error throw handling tests for SessionStartHandler and PromptSubmitHandler
• Verify formatter is not called when no memories exist (early return path)
• SessionStopHandler already had full coverage including non-Error throws
• All 195 unit tests pass, 0 failures

Closes GIT-57

Test plan

• All 17 handler tests pass
• Full unit test suite passes (195 tests)
• Type-check and lint clean

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Enhanced test coverage for error handling in request handlers to ensure non-standard error throws are properly caught and converted to Error objects.
  • Improved test assertions to verify that formatter operations are only executed when applicable data is available.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

📝 Walkthrough

Walkthrough

Test coverage expanded for PromptSubmitHandler and SessionStartHandler to verify non-Error throws are wrapped into Error objects and formatters are not invoked when memories are empty.

Changes

Cohort / File(s)	Summary
Handler Test Enhancements tests/unit/application/handlers/PromptSubmitHandler.test.ts, tests/unit/application/handlers/SessionStartHandler.test.ts	Added test cases for non-Error throw handling and modified "no memories" tests to verify formatter is not called when memories list is empty using a formatter spy that tracks invocation state.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• test: add comprehensive handler unit tests lisa#26 — Adds/modifies unit tests for the same handlers with overlapping scenarios for error-wrapping and formatter invocation validation.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: adding unit tests for hook handlers with the associated ticket reference.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch tony/git-57-unit-tests-for-hook-handlers

---

No actionable comments were generated in the recent review. 🎉

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR adds comprehensive unit test coverage for SessionStartHandler and PromptSubmitHandler, bringing them to parity with SessionStopHandler which already had full coverage. The tests focus on two key edge cases: handling non-Error throws and verifying the formatter is not called when no memories exist.

Changes:

• Added non-Error throw handling tests to verify error normalization logic in SessionStartHandler and PromptSubmitHandler
• Added tests verifying formatter is not called when the early return path is taken (no memories exist)
• Tests follow the same pattern as existing SessionStopHandler tests for consistency

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tests/unit/application/handlers/SessionStartHandler.test.ts	Added test for non-Error throw handling and formatter not called assertion for no-memories path
tests/unit/application/handlers/PromptSubmitHandler.test.ts	Added test for non-Error throw handling and formatter not called assertion for no-memories path

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.