test: add integration tests for commit-msg hook (GIT-84)

[TonyCasey]

Summary

• Adds comprehensive integration tests for the commit-msg hook end-to-end flow
• 22 tests using real temp git repos created via createTestRepo() helper
• Covers all acceptance criteria from GIT-84

Test Coverage

Basic Trailer Addition

• AI-Agent and AI-Model trailers
• AI-Confidence, AI-Lifecycle, AI-Memory-Id trailers

Memory Type Detection

• Decision detection from "because" clause
• Gotcha detection from "gotcha" keyword
• Convention detection from patterns

Tag Inference

• Tags from conventional commit scope
• Tags from staged file paths

Skip Conditions

• Skip if AI-Agent trailer already exists
• Skip trailers when no agent detected

Config Options

• autoAnalyze=false → only Agent/Model
• inferTags=false → no tags
• requireType=true → skip when no type detected
• Custom defaultLifecycle

Claude Code Environment Detection

• CLAUDECODE env var detection
• ANTHROPIC_MODEL env var

Edge Cases

• Empty commit message
• Whitespace-only message
• Special characters
• Multiline message
• Merge commit
• Amend commit

Test Plan

• All 22 integration tests pass
• Full test suite passes (503 tests)
• Type-check and lint pass

Closes GIT-84

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Added comprehensive integration test suite for AI-generated commit message trailers, thoroughly validating correct behavior across configuration options, environment detection, memory type inference, tag suggestions, skip conditions, and edge cases including empty messages, special characters, multiline content, and merge/amend commits.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

📝 Walkthrough

Walkthrough

Introduces comprehensive integration test suite for the git-mem commit-msg hook, validating AI-generated trailer appending across various scenarios including basic trailer addition, memory type detection, tag inference, configuration options, environment detection, and edge cases.

Changes

Cohort / File(s)

Summary

Commit-msg Hook Integration Tests tests/integration/hooks/hook-commit-msg.test.ts

Adds 581 lines of integration tests covering trailer generation (AI-Agent, AI-Model, AI-Confidence, AI-Lifecycle, AI-Memory-Id), memory type detection (AI-Decision, AI-Gotcha, AI-Convention), tag inference, skip conditions, config options (autoAnalyze, inferTags, requireType, defaultLifecycle), Claude Code environment detection, and edge cases (empty/whitespace/multiline/merge/amend messages). Includes test utilities for config and commit message file creation, and full lifecycle setup/teardown.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat: dual-write trailers in MemoryService.remember() (GIT-67) #36: Implements TrailerService.buildCommitMessage and addTrailers functionality that these integration tests directly exercise.
• feat: auto-detect agent/model and rework init prompts (GIT-73) #48: Implements agent/model detection and prepare-commit-msg behavior that the commit-msg hook tests validate.
• feat: liberate reads AI-* trailers from commit history (GIT-69) #40: Implements ExtractService/TrailerService trailer reading that relies on the AI-* trailers generated by this hook.

Suggested reviewers

• Copilot

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'test: add integration tests for commit-msg hook (GIT-84)' clearly and accurately describes the main change—adding comprehensive integration tests for the commit-msg hook, with a specific ticket reference.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch git-84

---

No actionable comments were generated in the recent review. 🎉

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR adds comprehensive integration tests for the commit-msg hook, implementing end-to-end testing for the hook's functionality using real temporary git repositories. The tests verify that the hook correctly analyzes commit messages and adds appropriate AI-* trailers based on pattern detection, conventional commit parsing, and configuration settings.

Changes:

• Adds 22 integration tests covering basic trailer addition, memory type detection, tag inference, skip conditions, configuration options, Claude Code environment detection, and edge cases
• Implements helper functions writeCommitMsgConfig() and createCommitMsgFile() for test setup
• Uses real git repositories created via the existing createTestRepo() helper from the integration test framework

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.