fix: default tasks list to today

[TonyCasey]

Summary

• default tasks list to --since today when no date filters are provided
• add --all to fetch older tasks explicitly
• add unit tests for default and --all behaviors

Testing

• node --import tsx --test tests/unit/src/lib/skills/shared/services/TaskCliService.test.ts

Linked Issues

Closes #87

Summary by CodeRabbit

• New Features

  • Added --all flag to the tasks list command, allowing users to view all tasks instead of defaulting to today's tasks only.

• Documentation

  • Updated configuration documentation to clarify that group IDs are derived and normalized from project folder paths.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR adds a --all flag to the tasks list command to display all tasks, disabling the default "since today" filter. It includes updates to group ID normalization documentation, implements append-only task storage, adds resource cleanup for neo4j connections, modifies directory traversal logic for project detection, and introduces comprehensive test coverage for the new date-filtering behavior.

Changes

Cohort / File(s)	Summary
Documentation Updates docs/configuration.md, src/project/.lisa/skills/tasks/SKILL.md	Updated user-facing documentation to reflect group ID normalization semantics and new --all and --since flags for the tasks list command with default "since today" behavior.
CLI Flag Handling src/lib/cli.ts, src/lib/skills/tasks/tasks.ts	Added --all flag support to tasks list command, propagating it through CLI argument parsing and into cliService invocation payload.
Date Filtering Logic src/lib/skills/shared/services/TaskCliService.ts	Implemented default "since today" filtering when no date range or --all flag is provided; defaults behavior is now controllable via the new all?: boolean interface property.
Group ID Utilities src/lib/skills/shared/utils/group-id.ts	Reworked directory traversal in findLisaDir to search to filesystem root instead of fixed depth limit; updated JSDoc to clarify return of canonical plus legacy group IDs.
GitHub Skills Enhancement src/lib/skills/github/github.ts	Implemented append-only task storage pattern (skip updates when task exists), added explicit neo4j disconnect in finally block for resource cleanup, enhanced groupId resolution from CLI arguments with fallback to getCurrentGroupId.
Unit Tests — Behavior Validation tests/unit/src/lib/skills/shared/services/TaskCliService.test.ts	Added comprehensive test coverage for default date filtering: verifies "since today" default when no filters applied, and verifies absence of since filter when --all flag is set.
Unit Tests — Refactoring tests/unit/src/lib/commands/doctor.test.ts, tests/unit/src/lib/skills/github/github.test.ts, tests/unit/src/lib/skills/shared/utils/group-id.test.ts	Updated test assertions to validate normalized group IDs, changed GitHub test expectations to reflect idempotent (no-update) behavior, and renamed test descriptions for clarity.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI as CLI Parser
    participant TaskSvc as TaskCliService
    participant TaskRepo as TaskService
    participant DB as Database

    Note over User,DB: Scenario: lisa tasks list (no flags)
    User->>CLI: tasks list
    CLI->>TaskSvc: run({all: false})
    TaskSvc->>TaskSvc: effectiveSince = parseDate('today')
    TaskSvc->>TaskRepo: list(groupIds, limit, {since: today})
    TaskRepo->>DB: query since=today
    DB-->>TaskRepo: filtered tasks
    TaskRepo-->>TaskSvc: tasks since today
    TaskSvc-->>CLI: display results

    Note over User,DB: Scenario: lisa tasks list --all
    User->>CLI: tasks list --all
    CLI->>TaskSvc: run({all: true})
    TaskSvc->>TaskSvc: effectiveSince = undefined
    TaskSvc->>TaskRepo: list(groupIds, limit, {})
    TaskRepo->>DB: query all tasks
    DB-->>TaskRepo: all tasks
    TaskRepo-->>TaskSvc: all tasks
    TaskSvc-->>CLI: display all results

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• bug: group-id logic inconsistent; should be canonical full folder path normalized #90 — Modifies group-id normalization, project-root traversal logic, and related test assertions; shares identical refactoring patterns in src/lib/skills/shared/utils/group-id.ts.
• feat(memory): add date-aware querying for memory and tasks #54 — Updates TaskCliService and task listing behavior including CLI flag handling and date-filtering defaults; affects overlapping code paths for task list command execution.

Poem

🐰 A flag called --all hops into view,
Tasks old and new, no filter restraint,
But "since today" becomes the default clue,
While neo4j cleanup prevents constraint,
The rabbit declares: "List tasks with grace!" ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 87

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@tests/unit/src/lib/skills/shared/services/TaskCliService.test.ts`:
- Around line 11-17: Remove the unused type import ITaskWriteOptions from the
import list in TaskCliService.test.ts; edit the import block that currently
lists ITaskService, ITaskListResult, ITaskWriteResult, ITaskLinkResult,
ITaskWriteOptions and delete only ITaskWriteOptions so the test no longer
imports an unused symbol.