Skip to content

Add SonarQube Action#1083

Merged
marci4 merged 2 commits intoTooTallNate:masterfrom
marci4:AddSonarAction
Oct 21, 2020
Merged

Add SonarQube Action#1083
marci4 merged 2 commits intoTooTallNate:masterfrom
marci4:AddSonarAction

Conversation

@marci4
Copy link
Copy Markdown
Collaborator

@marci4 marci4 commented Oct 10, 2020

Description

Add SonarQube action

Motivation and Context

Improve code qualtity

How Has This Been Tested?

No test needed, ony CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4
Copy link
Copy Markdown
Collaborator Author

marci4 commented Oct 10, 2020

Currently waiting for @TooTallNate to add the secret.

@marci4 marci4 added the Build label Oct 10, 2020
@marci4 marci4 marked this pull request as ready for review October 21, 2020 13:37
@marci4 marci4 added this to the Release 1.5.2 milestone Oct 21, 2020
@marci4 marci4 merged commit cfde6e0 into TooTallNate:master Oct 21, 2020
@marci4 marci4 deleted the AddSonarAction branch October 21, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Build

Projects

None yet

Milestone

Release 1.5.2

Development

Successfully merging this pull request may close these issues.

1 participant

@marci4