Skip to content

websocketimpl: avoid string copy unless logging trace message #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilipRoman merged 1 commit into from
Mar 5, 2023
Merged

websocketimpl: avoid string copy unless logging trace message #1301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/main/java/org/java_websocket/WebSocketImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,11 @@ public WebSocketImpl(WebSocketListener listener, Draft draft) {
*/
public void decode(ByteBuffer socketBuffer) {
assert (socketBuffer.hasRemaining());
log.trace("process({}): ({})", socketBuffer.remaining(),
(socketBuffer.remaining() > 1000 ? "too big to display"
: new String(socketBuffer.array(), socketBuffer.position(), socketBuffer.remaining())));

if (log.isTraceEnabled()) {
log.trace("process({}): ({})", socketBuffer.remaining(),
(socketBuffer.remaining() > 1000 ? "too big to display"
: new String(socketBuffer.array(), socketBuffer.position(), socketBuffer.remaining())));
}
if (readyState != ReadyState.NOT_YET_CONNECTED) {
if (readyState == ReadyState.OPEN) {
decodeFrames(socketBuffer);
Expand Down