Skip to content

Replace generic plots with Plotly specific plots#28

Merged
brichards64 merged 2 commits intoToolDAQ:masterfrom
jini-zh:plotlyplot
Dec 9, 2024
Merged

Replace generic plots with Plotly specific plots#28
brichards64 merged 2 commits intoToolDAQ:masterfrom
jini-zh:plotlyplot

Conversation

@jini-zh
Copy link
Contributor

@jini-zh jini-zh commented Oct 18, 2024

Instead of storing a generic plot in the database, store two JSON objects --- trace and layout --- that are arguments to Plotly plotting functions.

@jini-zh
Copy link
Contributor Author

jini-zh commented Oct 18, 2024

This pull request should be merged with ToolDAQ/ToolDAQFramework#32, ToolDAQ/middleman#9, ToolDAQ/libDAQInterface#12

@brichards64
Copy link
Contributor

can you make this update in the common functions.js as well

@jini-zh
Copy link
Contributor Author

jini-zh commented Oct 30, 2024

Rebased on top of current master and ported to html-Common.

In the first patch I introduced and unexported function GetPSQLJSON in functions.js which wraps GetPSQL to return its result as a JSON array. I think that this functionality should be included to GetPSQL and that functions.js needs a major overhaul in functions interfaces, so GetPSQLJSON is temporary while I'll be working on this.

Evgenii Zhemchugov added 2 commits December 9, 2024 14:44
Implement
* GetPSQJSON
* GetPlotlyPlot
* GetPlotlyPlots
* MakePlotlyPlot

Remove
* GetPlot
Not used anymore.
@brichards64 brichards64 merged commit 42d6be0 into ToolDAQ:master Dec 9, 2024
@jini-zh jini-zh deleted the plotlyplot branch December 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants