Enable alarm sound autoplay on Safari#29
Merged
brichards64 merged 1 commit intoToolDAQ:masterfrom Dec 9, 2024
Merged
Conversation
Contributor
|
can you move this to the same files in html-common |
ekumachidi
force-pushed
the
ce-play-alarm-on-safari
branch
from
77ca876 to
649996c
Compare
This fix - Adds a jump.mp3 because the `.ogg` failed on Safari tests - Updated the alarm_footer.js file to refactor the alarm sound handling and autoplay permission logic. - Added a new function checkAutoplayPermission() to check if autoplay for audio is allowed. - Added a new function showEnableAudioButton() to display a button to enable sound if autoplay is blocked. - Modified the TestAlarm() function to play the alarm sound using the playAlarmSound() function. - Updated the CheckAlarms() function to use the playAlarmSound() function when an alarm is triggered. - Added a new function playAlarmSound() to play the alarm sound with fallback for Safari. - Updated the footer.html file to include a hidden button to enable sound and a message for permission status.
ekumachidi
force-pushed
the
ce-play-alarm-on-safari
branch
from
649996c to
877b8d6
Compare
Contributor
Author
|
@brichards64 it is done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix:
jump.mp3because the.oggfailed on Safari tests