bugfix in sendcommand2nopadding.cpp#32
Merged
brichards64 merged 3 commits intoToolDAQ:masterfrom Dec 9, 2024
Merged
Conversation
disable ZMQ_IMMEDIATE option, it hangs if the socket can't connect to the desired client. Still, send returns true even when the client cannot be reached, which is misleading. ... not sure what to do about that....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disable ZMQ_IMMEDIATE in sendcommand2nopadding.cpp, since it hangs if it cannot connect.
(unfortunately without this option, 'socket::send' always returns true, even if the client cannot be reached... not sure what else can be done about this, though.)