Skip to content

[docs]: Fix link style in dark mode#12898

Merged
adishM98 merged 12 commits into
ToolJet:developfrom
Vegadjay:fix/doc-link-visible
Jun 9, 2025
Merged

[docs]: Fix link style in dark mode#12898
adishM98 merged 12 commits into
ToolJet:developfrom
Vegadjay:fix/doc-link-visible

Conversation

@Vegadjay
Copy link
Copy Markdown
Contributor

This PR addresses issue #12706. It resolves the problem where certain links were not visible by making adjustments to the CSS file. Additionally, I noticed that two links at the bottom are also not visible, so I will be updating their styles as well to ensure full visibility in dark and light both mode.

image
image
image
image

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 17, 2025

CLA assistant check
All committers have signed the CLA.

@Vegadjay Vegadjay marked this pull request as draft May 17, 2025 04:05
@Vegadjay Vegadjay marked this pull request as ready for review May 17, 2025 04:05
@PriteshKiri
Copy link
Copy Markdown
Contributor

Hey @Vegadjay,

Thanks for the update! I noticed that the breadcrumb and footer navigation link colors were changed to the blue link color. However, we’d like them to remain black in light mode (which is working fine) and white in dark mode.

Could you please update your PR accordingly? Let me know if you need any help!

@Vegadjay
Copy link
Copy Markdown
Contributor Author

Sure, @PriteshKiri. I'll make the updates to this PR by the end of today.

@Vegadjay
Copy link
Copy Markdown
Contributor Author

@PriteshKiri Sir, I will update all the changes. Please review them and let me know if any further modifications are needed.

@github-actions
Copy link
Copy Markdown
Contributor

@RudraPratik30 RudraPratik30 changed the title Fix/doc link visible in dark and light mode [docs]: Fix link style in dark mode May 19, 2025
@RudraPratik30
Copy link
Copy Markdown
Collaborator

Hey @Vegadjay,

Thanks for the contribution!

In this issue, you're also supposed to work on the hyperlinks that are not visible in dark mode. Specifically, links inside the warning or info boxes are not visible in dark mode — check out this example.

Additionally, could you also fix the GitHub and X logos in the footer for dark mode?

@Vegadjay
Copy link
Copy Markdown
Contributor Author

@RudraPratik30 Why not sir, I’ll do that and keep you informed.

@Vegadjay
Copy link
Copy Markdown
Contributor Author

Vegadjay commented May 20, 2025

@RudraPratik30 Sir, I have made all the changes. Please review them, and if there are any mistakes or updates needed, please let me know.

  • Icons changes dark mode
    image

  • Icons changes light mode
    image

  • Warning section Link color changes dark mode
    image

  • Warning section Link color changes changes light mode
    image

  • Mac os, Ubantu tag color change dark mode
    image

  • Mac os, Ubantu tag color change light mode
    image

@github-actions
Copy link
Copy Markdown
Contributor

RudraPratik30
RudraPratik30 previously approved these changes May 22, 2025
Copy link
Copy Markdown
Collaborator

@RudraPratik30 RudraPratik30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Vegadjay !

Thanks for contributing to ToolJet!

The changes look good to me, and I'm forwarding the PR to my team for a final review. Once that's done, we'll proceed with merging it. Your PR will be merged soon!

@Vegadjay
Copy link
Copy Markdown
Contributor Author

@RudraPratik30 Thankyou sir for guide me and apperciate me.

Comment thread docs/src/css/custom.css
@sonarqubecloud
Copy link
Copy Markdown

@Vegadjay
Copy link
Copy Markdown
Contributor Author

@RudraPratik30 @PriteshKiri Please review the latest changes and proceed with my pull request.

@github-actions
Copy link
Copy Markdown
Contributor

@Vegadjay
Copy link
Copy Markdown
Contributor Author

@PriteshKiri Sir, if all the changes are complete, please proceed further. If there are any mistakes or additional requirements, kindly let me know

@PriteshKiri
Copy link
Copy Markdown
Contributor

Hey @Vegadjay
Thank you so much for your contribution! 🙌
The PR looks good to me. Will get this merged soon.

@Vegadjay
Copy link
Copy Markdown
Contributor Author

Vegadjay commented Jun 6, 2025

Hello @PriteshKiri and @RudraPratik30 Sir,
Could you please share some information regarding this PR? Just wanted to check.

Copy link
Copy Markdown
Collaborator

@karan-rathod-316 karan-rathod-316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@adishM98 adishM98 merged commit adbb7b7 into ToolJet:develop Jun 9, 2025
140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants