Conversation
vjaris42
requested review from
akshaysasidrn,
gsmithun4,
johnsoncherian,
kavinvenkatachalam and
shah21
as code owners
nechalmaggon
added
the
create-ee-lts-review-app
nechalmaggon
added
destroy-ee-lts-review-app
gsmithun4
requested changes
Feb 11, 2026
server/src/modules/modules/module.ts
Outdated
| GroupPermissionsRepository, | ||
| ValidAppGuard, | ||
| ], | ||
| exports: [AppsUtilService], |
Collaborator
There was a problem hiding this comment.
should not be exported. already exported from apps module
Contributor
🚀 EE LTS Review App Deployed!
Deployed using DockerHub-based pipeline - LTS Edition |
github-actions
bot
added
active-ee-lts-review-app
…check, and UI inconsistencie
|
Pratush seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
🔄 EE LTS Review App RebuildingNew commit Using cached layers for faster build |
Contributor
🔄 EE LTS Review App RebuildingNew commit Using cached layers for faster build |
Contributor
🔄 EE LTS Review App RebuildingNew commit Using cached layers for faster build |
Contributor
🔄 EE Pre-release Review App RebuildingNew commit Using cached layers for faster build |
Contributor
🔄 EE Pre-release Review App RebuildingNew commit Using cached layers for faster build |
…ccess fixed granular access flaky case
Contributor
🔄 EE Pre-release Review App RebuildingNew commit Using cached layers for faster build |
Contributor
🔄 EE Pre-release Review App RebuildingNew commit Using cached layers for faster build |
Contributor
🔄 EE Pre-release Review App RebuildingNew commit Using cached layers for faster build |
Collaborator
|
🔍 Checking linked submodule PRs for ✅ ee-server PR - https://github.com/ToolJet/ee-server/pull/364 📝 Note: The submodule PRs will be auto-merged once you merge this base PR-15028 into |
github-actions
bot
removed
the
active-ee-pre-release-review-app
akshaysasidrn
added a commit
that referenced
this pull request
Mar 23, 2026
Restores FOLDER enum, entities (FoldersGroupPermissions, GroupFolders), type definitions, FEATURE_KEY entries, and relation mappings that were dropped when PR #15028 was merged to main. Also fixes EE constants to use folderCRUD (matching actual DB schema) instead of folderCreate/ folderDelete.
akshaysasidrn
pushed a commit
that referenced
this pull request
Mar 24, 2026
* feat: Folder permission system * fix(group-permissions): resolve custom group validation, folder edit check, and UI inconsistencie * edit folder container && no folder in custom resource * fix the ui for custom in empty state * fix: coercion logic for folder permissions * feat: enhance folder permissions handling in app components * feat: add folder granular permissions handling in user apps permissions * feat: implement granular folder permissions in ability guard and service * feat: improve error handling for folder permissions with specific messages * feat: enhance EnvironmentSelect component to handle disabled state and improve display logic * chore: bump ee submodules * feat: Update permission prop to isEditable in BaseManageGranularAccess component * chore: bump ee server submodule * fix: refine folder visibility logic based on user permissions * feat: enhance MultiValue rendering and styling for "All environments" option * feat: implement folder ownership checks and enhance app permissions handling * feat: enhance folder permissions handling for app ownership and actions * chore: clarify folder creation and deletion permissions in workspace context * fix: update folder permission labels * fixed folder permission cases * fixed css class issue * minor fix * feat: streamline folder permissions handling by removing redundant checks and simplifying access logic * refactor: made error message consistent * fix: add missing permission message for folder deletion action * refactor: consolidate forbidden messages for folder actions and maintain consistency * feat: streamline permission handling and improve app visibility logic * fix: remove default access denial message in AbilityGuard * fixed all user page functionality falky case * Fixed profile flaky case * fixed granular access flaky case * chore: revert package-lock.json * chore: revert frontend/package-lock.json to main * refactor: revert folder operations * fix: remove unused AppEnvironmentsModule and AppsUtilService exports --------- Co-authored-by: gsmithun4 <gsmithun4@gmail.com> Co-authored-by: Pratush <pratush@Pratushs-MBP.lan> Co-authored-by: Shantanu Mane <maneshantanu.20@gmail.com> Co-authored-by: Yukti Goyal <yuktigoyal02@gmail.com>
akshaysasidrn
added a commit
that referenced
this pull request
Mar 24, 2026
Resolves ~19 merge conflicts from main's PR #15028 (app-folder permission system). Key changes: - Replace folderCRUD with folderCreate/folderDelete (main's split) - Keep dataSourceFolderCRUD for DS folder feature - Accept main's folder entity (createdBy), ability refactor, folder permission guards, and CASL rules - Add DS folder types/endpoints alongside main's folder types - Delete redundant migration 1774255111000 (superseded by main's 1766500000000-AddFolderPermissionSystem) - Fix EE external-apis and ability services for new column names - Update all test helpers to use new column names Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA checklist