Chore: Add migration to backfill Table component properties#15982
Merged
kavinvenkatachalam merged 2 commits intorelease/appbuilder-s26from Apr 17, 2026
Merged
Chore: Add migration to backfill Table component properties#15982kavinvenkatachalam merged 2 commits intorelease/appbuilder-s26from
kavinvenkatachalam merged 2 commits intorelease/appbuilder-s26from
Conversation
…operties for Table components * Implemented a new migration to set default values for showRefreshButton, enableExpandableRows, and expansionHeight in Table components. * Added logging for migration progress and success. * Included functionality to delete app history for structural migrations if updates occur.
devanshu052000
requested review from
Copilot,
johnsoncherian and
kavinvenkatachalam
…operty in Table components * Deleted the migration file that backfilled the showRefreshButton property, as it is no longer needed. * This cleanup helps maintain the codebase by removing unused files.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new server-side data migration to backfill missing Table component properties in the components.properties JSON and (when updates occur) purge related app_history to avoid restoring incompatible history after the structural change.
Changes:
- Introduces a batched backfill migration for
Tablecomponentproperties(showRefreshButton,enableExpandableRows,expansionHeight). - Adds progress logging for visibility during deployment runs.
- Triggers structural app history cleanup when any rows are updated.
Comments suppressed due to low confidence (3)
server/data-migrations/1776432217565-BackfillRefreshButtonAndExpandableRowsForTable.ts:21
- This migration only targets rows missing
showRefreshButton. Since an earlier migration (1776425096777-BackfillShowRefreshButtonTable.ts) already backfillsshowRefreshButton, by the time this migration runs on an upgrade the COUNT will be 0 andenableExpandableRows/expansionHeightwill never be backfilled. Update the WHERE clause(s) to detect missingenableExpandableRowsand/orexpansionHeightas well (or any of the three keys).
server/data-migrations/1776432217565-BackfillRefreshButtonAndExpandableRowsForTable.ts:51 properties = properties::jsonb || patchoverwrites existing keys with the patch values. If aTablecomponent is missingshowRefreshButtonbut already has a user-setenableExpandableRowsorexpansionHeight, this UPDATE will reset them to defaults. Consider updating each key only when it is absent (e.g., viaCASE/jsonb_setper key) so existing values are preserved.
server/data-migrations/1776432217565-BackfillRefreshButtonAndExpandableRowsForTable.ts:69- App history cleanup currently selects all app versions that contain any
Tablecomponent (WHERE c.type = ANY($1)) oncetotalUpdated > 0. That can delete history for app versions that were not modified by this migration. If possible, scope the cleanup query to only app versions that actually had components updated (e.g., select DISTINCT app_version_id using the same “missing property” predicate used for the backfill, or collect affected app_version_ids during batching).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johnsoncherian
approved these changes
Apr 17, 2026
kavinvenkatachalam
approved these changes
Apr 17, 2026
vavinash992
pushed a commit
that referenced
this pull request
Apr 24, 2026
* feat: add migration to backfill refresh button and expandable rows properties for Table components * Implemented a new migration to set default values for showRefreshButton, enableExpandableRows, and expansionHeight in Table components. * Added logging for migration progress and success. * Included functionality to delete app history for structural migrations if updates occur. * chore: remove obsolete migration for backfilling showRefreshButton property in Table components * Deleted the migration file that backfilled the showRefreshButton property, as it is no longer needed. * This cleanup helps maintain the codebase by removing unused files.
johnsoncherian
added a commit
that referenced
this pull request
Apr 27, 2026
* feat: add auto-sort feature to AI queries and update related components * feat: add Generate Query button and update selected query handling in data query slice * chore: update subproject commits for frontend and server * chore: update subproject commits for frontend and server * chore: update subproject commits for frontend and server * Feat: Expandable rows in Table component (#15827) * Add event and toggle for expandable rows * Add column to expand in table * Setup store * Implement expandable rows in table * expose rowData for children components and make all containers other than first row not editable * Added support for dynamic height for each expandable row * Update submodule reference * Fix: Virtualizer not getting updated in a few cases when row is expanded or collapsed and nested table wasn't getting expanded as expected * Update submodule references * Fix: Remove 'children' and 'data' exposed variables from Table * Fix: Clear exposed values when expandable rows is toggled * Fix: Remove dynamic height for expanded row for phase 1 * Fix: Move 'Enable expnadable rows' toggle to 'Row selection' section instead of 'Additional Actions' * Update submodule references * Implement lazy resolution for expandable rows in Table component - Introduced `updateCustomResolvablesLazy` and `resolveExpandedRows` to handle row data without immediate resolution, improving performance for expandable rows. - Added `clearLazyRowIndices` to manage row indices when rows are expanded or collapsed. - Updated the store to include `lazyResolvableParents` and `lazyRowIndices` for better state management of lazy-loaded components. - Created a new `tableComponentSlice` to encapsulate logic related to table components, enhancing modularity and maintainability. * Fix: Use similar approach for finding indices to be resolved using separate utility function * Fix: Implement proper store cleanup incase table is deleted or expandable rows is disabled * Refactor: Rename `clearLazyRowIndices` to `cleanupLazyResolvables` for clarity - Updated the Table component to use `cleanupLazyResolvables` instead of `clearLazyRowIndices` for better readability and understanding of its purpose. - Adjusted the logic in the `resolveExpandedRows` function to populate custom resolvables only for expanded rows, improving performance and state management. - Enhanced cleanup logic in the component's effect hooks to ensure proper resource management when the component unmounts or when expandable rows are toggled. * Update submodule reference * Fix: Grid outline not getting highlighted when component is being dragged inside it * Fix: Default height of expanded container * Fix: Row expand trigger style * Fix: Expanded container background color and padding * Fix: Container component crashes when components is dropped from Table row's expanded container * Update submodule references * updat esubmodule references * Update submodule references * Refactor TableData component to use constants for row heights, improving readability and maintainability. * Refactor TableContainer and useTable hooks to integrate expandedRows state, enhancing row expansion functionality. * Add 'Table' to restricted widgets configuration * Enhance appCanvasConstants with row-scoped widget types and resolvable key mappings; refactor Container and codeHinterSlice to utilize new constants for improved readability and maintainability. * Add nesting level limits for widgets in appCanvasConstants; refactor Grid and dragEnd logic to enforce nesting restrictions based on new limits, enhancing widget organization and preventing excessive nesting. * Update sbumodule reference * feat: add refresh button functionality to table components (#15912) * feat: add refresh button functionality to table components * fix: update refresh button icon from IconRefresh to IconReload * Made the showRefershButton to false by default * supported support for data queries as well other than raw json * Used dependency graph to check the query reference * Added migration for show refresh button to support backward compatibility * fix: update loading state handling to include refresh status in Table and Header components * enhanceed migration to backfill showRefreshButton property for Table components * [enhancement] : Added caption in the options for dropdown and multi-select components (#15935) * Feature: Add caption support to DropdownV2 options * Feature: Enhance DropdownV2 and MultiselectV2 with caption support * Chore: Add migration to backfill Table component properties (#15982) * feat: add migration to backfill refresh button and expandable rows properties for Table components * Implemented a new migration to set default values for showRefreshButton, enableExpandableRows, and expansionHeight in Table components. * Added logging for migration progress and success. * Included functionality to delete app history for structural migrations if updates occur. * chore: remove obsolete migration for backfilling showRefreshButton property in Table components * Deleted the migration file that backfilled the showRefreshButton property, as it is no longer needed. * This cleanup helps maintain the codebase by removing unused files. * fixed selector issue (#15988) * fix: gate JS library loading on license fetch to fix public/released apps (#15994) JS libraries were silently skipped on public and released apps because featureAccess?.appJsLibraries was still undefined when isComponentLayoutReady fired. Introduces isLicenseFetched flag and handles fetch errors so the gate is never blocked indefinitely for unauthenticated users. * Fix: Listview children not getting rendered inside Table expanded row (#16000) * Refactor componentsSlice to generalize ancestor type checks for row-scoped widgets. Removed obsolete check for Listview and Kanban, replacing it with a more flexible ROW_SCOPED_WIDGET_TYPES array. Updated comments for clarity on parent index handling. * Updated comments to reflect changes in handling parent indices and replaced references to Listview with a more general row-scoped ancestor terminology. * Unable to clone/import app with multiple versions (#16001) * feat: add workflow, module, workspace, and custom group counts to telemetry (#15932) * feat: add workflow, module, workspace, and user group counts to telemetry Add 4 new metrics to the telemetry payload sent to hub.tooljet.io: - total_workflows: count of apps with type 'workflow' - total_modules: count of apps with type 'module' - total_workspaces: count of all organizations - total_user_groups: count of all permission groups Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: filter telemetry user group count to custom groups only Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fixed case (#16003) * Fixed the Ui for supabase for where and sort fields (#15965) * Fixed the Ui for supabase for where and sort fields * Bump version to 3.20.148-lts across all components --------- Co-authored-by: gsmithun4 <gsmithun4@gmail.com> * fix: handle null check in PreviewCodeBlock (#15597) * Fix: read AWS secret key from AWS_SECRET_ACCESS_KEY in marketplace upload-to-s3 (#16047) aws-actions/configure-aws-credentials@v4 exports AWS_SECRET_ACCESS_KEY (with the AWS_ prefix), but the S3 uploader was reading SECRET_ACCESS_KEY, leaving credentials.secretAccessKey undefined. aws-sdk v2 silently fell back to the default credential provider chain so this typo went unnoticed for years; the aws-sdk v3 migration in #15147 made an explicit credentials object authoritative, so every upload since has failed with "Resolved credential object is not valid" (0/567 files on recent runs). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(file-button): update default icon and fix section categorization (#15734) * fix(file-button): update default icon and fix section categorization - Change default icon of FileButton component from IconHome2 to IconFileUpload for better UX - Set iconVisibility to true by default for FileButton - Add FileButton to Miscellaneous section in component library - Replace ButtonGroup with ButtonGroupV2 in Buttons section in component library * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix(file-button): align icon validation defaultValue with new default (IconFileUpload) Agent-Logs-Url: https://github.com/ToolJet/ToolJet/sessions/d37904fa-086e-42be-afd6-7a2918bce6e2 Co-authored-by: johnsoncherian <57667706+johnsoncherian@users.noreply.github.com> * feat(sectionConfig): add FileButton to Buttons section and remove from Miscellaneous --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * Dynamic height (#15993) * Dynamic height revamp * Redundant code cleanup * Minor fix * Add collapse on hide toggle to button component * Fixed table collapse on hidden toggle missing * Fixed listview min height issue * Listview footer not at the bottom when dynamic height enabled fix * Extra padding removed from textarea * Fixed CollapseOnHide missing for KeyValuePair, CodeEditor, Richtextarea * Fixed container height not getting properly calculated when a component with alignment set to top is present * Accordian causing overlap fix * Fix for container based components not recomputing height when invisible by default * Toggling dynamic height toggle using fx fix * Backfill CollapseOnHidden * Minor listview fix * Feat : MSSQL gui mode (#15826) * GUI mode abstraction and GUI mode for postgresql * CSS Issue and Query response fixes * mssql changes for GUI mode * mssql upsert operation * mssql bug fix for errors faced in pgsql * bug fix for MSSQL operations * ui changes (#15964) * dev testing bug fixes * Bulk update backward compatibility fix * chore: update version to 3.20.149-lts --------- Co-authored-by: abhijeet760 <abhijeet@tooljet.com> Co-authored-by: gsmithun4 <gsmithun4@gmail.com> --------- Co-authored-by: Devanshu Rastogi <devanshu.rastogi05@gmail.com> Co-authored-by: Manish Kushare <37823141+manishkushare@users.noreply.github.com> Co-authored-by: YuktiGoyal02 <100783212+YuktiGoyal02@users.noreply.github.com> Co-authored-by: Kavin Venkatachalam <50441969+kavinvenkatachalam@users.noreply.github.com> Co-authored-by: Shaurya Sharma <79473274+shaurya-sharma064@users.noreply.github.com> Co-authored-by: Akshay <akshaysasidrn@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Siddharth Pundir <145639697+Siddharthpl@users.noreply.github.com> Co-authored-by: gsmithun4 <gsmithun4@gmail.com> Co-authored-by: Johnson Cherian <johnsonc.dev@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Ganesh Kumar <40178541+ganesh8056@users.noreply.github.com> Co-authored-by: abhijeet760 <abhijeet@tooljet.com>
gsmithun4
added a commit
that referenced
this pull request
Apr 28, 2026
* fix: handle null check in PreviewCodeBlock (#15597) * replace appsmith and retool from ai generated messages if they show up (#16039) * 🚀 chore: update submodules to latest lts-3.16 after auto-merge (#16040) Co-authored-by: johnsoncherian <57667706+johnsoncherian@users.noreply.github.com> * Fix: read AWS secret key from AWS_SECRET_ACCESS_KEY in marketplace upload-to-s3 (#16047) aws-actions/configure-aws-credentials@v4 exports AWS_SECRET_ACCESS_KEY (with the AWS_ prefix), but the S3 uploader was reading SECRET_ACCESS_KEY, leaving credentials.secretAccessKey undefined. aws-sdk v2 silently fell back to the default credential provider chain so this typo went unnoticed for years; the aws-sdk v3 migration in #15147 made an explicit credentials object authoritative, so every upload since has failed with "Resolved credential object is not valid" (0/567 files on recent runs). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(file-button): update default icon and fix section categorization (#15734) * fix(file-button): update default icon and fix section categorization - Change default icon of FileButton component from IconHome2 to IconFileUpload for better UX - Set iconVisibility to true by default for FileButton - Add FileButton to Miscellaneous section in component library - Replace ButtonGroup with ButtonGroupV2 in Buttons section in component library * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix(file-button): align icon validation defaultValue with new default (IconFileUpload) Agent-Logs-Url: https://github.com/ToolJet/ToolJet/sessions/d37904fa-086e-42be-afd6-7a2918bce6e2 Co-authored-by: johnsoncherian <57667706+johnsoncherian@users.noreply.github.com> * feat(sectionConfig): add FileButton to Buttons section and remove from Miscellaneous --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * Dynamic height (#15993) * Dynamic height revamp * Redundant code cleanup * Minor fix * Add collapse on hide toggle to button component * Fixed table collapse on hidden toggle missing * Fixed listview min height issue * Listview footer not at the bottom when dynamic height enabled fix * Extra padding removed from textarea * Fixed CollapseOnHide missing for KeyValuePair, CodeEditor, Richtextarea * Fixed container height not getting properly calculated when a component with alignment set to top is present * Accordian causing overlap fix * Fix for container based components not recomputing height when invisible by default * Toggling dynamic height toggle using fx fix * Backfill CollapseOnHidden * Minor listview fix * Removed old render preview file * Feat : MSSQL gui mode (#15826) * GUI mode abstraction and GUI mode for postgresql * CSS Issue and Query response fixes * mssql changes for GUI mode * mssql upsert operation * mssql bug fix for errors faced in pgsql * bug fix for MSSQL operations * ui changes (#15964) * dev testing bug fixes * Bulk update backward compatibility fix * chore: update version to 3.20.149-lts --------- Co-authored-by: abhijeet760 <abhijeet@tooljet.com> Co-authored-by: gsmithun4 <gsmithun4@gmail.com> * Update Storybook deploy workflow for Netlify * fixed reset password cases (#16074) * [feat] : Introduce new column called Tags (#16023) * Add TagsV2 support in Table component * Enhance TagsV2 support in Table component by adding 'Allow multiple selection' option and updating related properties. Adjust styles and refactor TagsRenderer for improved functionality and maintainability. * Add default select options for select/multiselect/tagsV2 columns in Table component. Refactor OptionsList and useColumnManager to utilize these defaults, enhancing consistency and maintainability. * Refactor TagsRenderer to improve multi-value handling and integrate new icon for value removal. Update generateColumnsData to set 'allowMultipleSelection' default to false, enhancing configuration clarity. * Enhance TagsV2 support in useColumnManager and TagsRenderer. Added default properties for 'tagsV2' column type, including sortTags, allowMultipleSelection, and autoAssignColors. Improved multi-value handling in TagsRenderer and updated styles for better UI consistency. * Update TagsRenderer styles: replace boxShadow with border for improved UI consistency. * fix * fix * Enhance TagsRenderer: Introduce auto-assigned chip color functionality and streamline background color handling for tag chips, improving visual consistency and customization options. * [Feat] : Add column pinning to Table (#15889) * feat: add column pinning functionality to table component - Introduced a new PinColumnControl component for managing column pinning. - Updated PropertiesTabElements to include the pinning control. - Enhanced useColumnManager hook to handle pinPosition state. - Added utility functions for calculating pinned column offsets and styles. - Updated Table and TableHeader components to support pinned columns visually. - Added CSS styles for pinned columns and their boundaries. - Ensured default pinPosition is set to 'unpinned' for new columns. * feat: enhance column pinning logic in table component - Added support for dynamic column pinning based on the `useDynamicColumn` state. - Updated `pinPosition` logic to handle dynamic freezing of columns, allowing for 'left' or 'right' pinning based on resolved values. - Ensured compatibility with existing column properties and visibility checks. * Enhance table pinning functionality by ensuring the selection column is pinned to the left when other columns are pinned. Update styles to maintain consistent background colors for pinned columns during selection and hover states. * Feat/upgrade coding assistant (#16075) * feat: add auto-sort feature to AI queries and update related components * feat: add Generate Query button and update selected query handling in data query slice * chore: update subproject commits for frontend and server * chore: update subproject commits for frontend and server * chore: update subproject commits for frontend and server * Feat: Expandable rows in Table component (#15827) * Add event and toggle for expandable rows * Add column to expand in table * Setup store * Implement expandable rows in table * expose rowData for children components and make all containers other than first row not editable * Added support for dynamic height for each expandable row * Update submodule reference * Fix: Virtualizer not getting updated in a few cases when row is expanded or collapsed and nested table wasn't getting expanded as expected * Update submodule references * Fix: Remove 'children' and 'data' exposed variables from Table * Fix: Clear exposed values when expandable rows is toggled * Fix: Remove dynamic height for expanded row for phase 1 * Fix: Move 'Enable expnadable rows' toggle to 'Row selection' section instead of 'Additional Actions' * Update submodule references * Implement lazy resolution for expandable rows in Table component - Introduced `updateCustomResolvablesLazy` and `resolveExpandedRows` to handle row data without immediate resolution, improving performance for expandable rows. - Added `clearLazyRowIndices` to manage row indices when rows are expanded or collapsed. - Updated the store to include `lazyResolvableParents` and `lazyRowIndices` for better state management of lazy-loaded components. - Created a new `tableComponentSlice` to encapsulate logic related to table components, enhancing modularity and maintainability. * Fix: Use similar approach for finding indices to be resolved using separate utility function * Fix: Implement proper store cleanup incase table is deleted or expandable rows is disabled * Refactor: Rename `clearLazyRowIndices` to `cleanupLazyResolvables` for clarity - Updated the Table component to use `cleanupLazyResolvables` instead of `clearLazyRowIndices` for better readability and understanding of its purpose. - Adjusted the logic in the `resolveExpandedRows` function to populate custom resolvables only for expanded rows, improving performance and state management. - Enhanced cleanup logic in the component's effect hooks to ensure proper resource management when the component unmounts or when expandable rows are toggled. * Update submodule reference * Fix: Grid outline not getting highlighted when component is being dragged inside it * Fix: Default height of expanded container * Fix: Row expand trigger style * Fix: Expanded container background color and padding * Fix: Container component crashes when components is dropped from Table row's expanded container * Update submodule references * updat esubmodule references * Update submodule references * Refactor TableData component to use constants for row heights, improving readability and maintainability. * Refactor TableContainer and useTable hooks to integrate expandedRows state, enhancing row expansion functionality. * Add 'Table' to restricted widgets configuration * Enhance appCanvasConstants with row-scoped widget types and resolvable key mappings; refactor Container and codeHinterSlice to utilize new constants for improved readability and maintainability. * Add nesting level limits for widgets in appCanvasConstants; refactor Grid and dragEnd logic to enforce nesting restrictions based on new limits, enhancing widget organization and preventing excessive nesting. * Update sbumodule reference * feat: add refresh button functionality to table components (#15912) * feat: add refresh button functionality to table components * fix: update refresh button icon from IconRefresh to IconReload * Made the showRefershButton to false by default * supported support for data queries as well other than raw json * Used dependency graph to check the query reference * Added migration for show refresh button to support backward compatibility * fix: update loading state handling to include refresh status in Table and Header components * enhanceed migration to backfill showRefreshButton property for Table components * [enhancement] : Added caption in the options for dropdown and multi-select components (#15935) * Feature: Add caption support to DropdownV2 options * Feature: Enhance DropdownV2 and MultiselectV2 with caption support * Chore: Add migration to backfill Table component properties (#15982) * feat: add migration to backfill refresh button and expandable rows properties for Table components * Implemented a new migration to set default values for showRefreshButton, enableExpandableRows, and expansionHeight in Table components. * Added logging for migration progress and success. * Included functionality to delete app history for structural migrations if updates occur. * chore: remove obsolete migration for backfilling showRefreshButton property in Table components * Deleted the migration file that backfilled the showRefreshButton property, as it is no longer needed. * This cleanup helps maintain the codebase by removing unused files. * fixed selector issue (#15988) * fix: gate JS library loading on license fetch to fix public/released apps (#15994) JS libraries were silently skipped on public and released apps because featureAccess?.appJsLibraries was still undefined when isComponentLayoutReady fired. Introduces isLicenseFetched flag and handles fetch errors so the gate is never blocked indefinitely for unauthenticated users. * Fix: Listview children not getting rendered inside Table expanded row (#16000) * Refactor componentsSlice to generalize ancestor type checks for row-scoped widgets. Removed obsolete check for Listview and Kanban, replacing it with a more flexible ROW_SCOPED_WIDGET_TYPES array. Updated comments for clarity on parent index handling. * Updated comments to reflect changes in handling parent indices and replaced references to Listview with a more general row-scoped ancestor terminology. * Unable to clone/import app with multiple versions (#16001) * feat: add workflow, module, workspace, and custom group counts to telemetry (#15932) * feat: add workflow, module, workspace, and user group counts to telemetry Add 4 new metrics to the telemetry payload sent to hub.tooljet.io: - total_workflows: count of apps with type 'workflow' - total_modules: count of apps with type 'module' - total_workspaces: count of all organizations - total_user_groups: count of all permission groups Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: filter telemetry user group count to custom groups only Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fixed case (#16003) * Fixed the Ui for supabase for where and sort fields (#15965) * Fixed the Ui for supabase for where and sort fields * Bump version to 3.20.148-lts across all components --------- Co-authored-by: gsmithun4 <gsmithun4@gmail.com> * fix: handle null check in PreviewCodeBlock (#15597) * Fix: read AWS secret key from AWS_SECRET_ACCESS_KEY in marketplace upload-to-s3 (#16047) aws-actions/configure-aws-credentials@v4 exports AWS_SECRET_ACCESS_KEY (with the AWS_ prefix), but the S3 uploader was reading SECRET_ACCESS_KEY, leaving credentials.secretAccessKey undefined. aws-sdk v2 silently fell back to the default credential provider chain so this typo went unnoticed for years; the aws-sdk v3 migration in #15147 made an explicit credentials object authoritative, so every upload since has failed with "Resolved credential object is not valid" (0/567 files on recent runs). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(file-button): update default icon and fix section categorization (#15734) * fix(file-button): update default icon and fix section categorization - Change default icon of FileButton component from IconHome2 to IconFileUpload for better UX - Set iconVisibility to true by default for FileButton - Add FileButton to Miscellaneous section in component library - Replace ButtonGroup with ButtonGroupV2 in Buttons section in component library * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix(file-button): align icon validation defaultValue with new default (IconFileUpload) Agent-Logs-Url: https://github.com/ToolJet/ToolJet/sessions/d37904fa-086e-42be-afd6-7a2918bce6e2 Co-authored-by: johnsoncherian <57667706+johnsoncherian@users.noreply.github.com> * feat(sectionConfig): add FileButton to Buttons section and remove from Miscellaneous --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * Dynamic height (#15993) * Dynamic height revamp * Redundant code cleanup * Minor fix * Add collapse on hide toggle to button component * Fixed table collapse on hidden toggle missing * Fixed listview min height issue * Listview footer not at the bottom when dynamic height enabled fix * Extra padding removed from textarea * Fixed CollapseOnHide missing for KeyValuePair, CodeEditor, Richtextarea * Fixed container height not getting properly calculated when a component with alignment set to top is present * Accordian causing overlap fix * Fix for container based components not recomputing height when invisible by default * Toggling dynamic height toggle using fx fix * Backfill CollapseOnHidden * Minor listview fix * Feat : MSSQL gui mode (#15826) * GUI mode abstraction and GUI mode for postgresql * CSS Issue and Query response fixes * mssql changes for GUI mode * mssql upsert operation * mssql bug fix for errors faced in pgsql * bug fix for MSSQL operations * ui changes (#15964) * dev testing bug fixes * Bulk update backward compatibility fix * chore: update version to 3.20.149-lts --------- Co-authored-by: abhijeet760 <abhijeet@tooljet.com> Co-authored-by: gsmithun4 <gsmithun4@gmail.com> --------- Co-authored-by: Devanshu Rastogi <devanshu.rastogi05@gmail.com> Co-authored-by: Manish Kushare <37823141+manishkushare@users.noreply.github.com> Co-authored-by: YuktiGoyal02 <100783212+YuktiGoyal02@users.noreply.github.com> Co-authored-by: Kavin Venkatachalam <50441969+kavinvenkatachalam@users.noreply.github.com> Co-authored-by: Shaurya Sharma <79473274+shaurya-sharma064@users.noreply.github.com> Co-authored-by: Akshay <akshaysasidrn@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Siddharth Pundir <145639697+Siddharthpl@users.noreply.github.com> Co-authored-by: gsmithun4 <gsmithun4@gmail.com> Co-authored-by: Johnson Cherian <johnsonc.dev@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Ganesh Kumar <40178541+ganesh8056@users.noreply.github.com> Co-authored-by: abhijeet760 <abhijeet@tooljet.com> * 🚀 chore: update submodules to latest lts-3.16 after auto-merge (#16153) Co-authored-by: johnsoncherian <57667706+johnsoncherian@users.noreply.github.com> * Mysql batching and operations wrapped in transaction (#16094) * restapi save issue (#16095) * restapi save issue * Fixed restapi confirm box --------- Co-authored-by: Srimanitejas123 <mani@tooljet.com> * fix(Rocket/Switch): tighten track and thumb dimensions (#16017) Track 36×20 → 28×16, thumb 16×16 → 12×12, travel normalized to ±5px so on/off positions sit flush inside the track padding. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(rocket): add Popover component (#16009) Adds shadcn Popover primitive and Rocket HOC wrapping it with ToolJet design tokens, plus Storybook stories and spec. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: bump version to 3.20.150-lts across all components (#16195) * Refactor normalizeQueryTransformationOptions to simplify key normalization and remove redundant code (#16103) * Refactor normalizeQueryTransformationOptions to simplify key normalization and remove redundant code * fix: whitelist options to normalise Co-authored-by: Copilot <copilot@github.com> --------- Co-authored-by: Copilot <copilot@github.com> * Feature: TruncatingText primitive and Rocket overflow polish (#16096) * feat(Rocket): add TruncatingText primitive and overflow polish - New TruncatingText primitive: ellipsis-clipped span that sets the native `title` attribute when the text overflows. Detects via ResizeObserver + MutationObserver so context-driven content (Radix SelectValue, Base UI ComboboxValue) re-measures on selection change. - New useInputOverflowTitle hook for inputs, wired into ComboboxInput always-on. Adds `[&_input]:tw-truncate` so blurred values show the ellipsis, and resets scrollLeft on blur for reliable redraw. - Select.spec.md and Combobox.spec.md document an opt-in TruncatingText composition pattern. Long-overflow stories added for TruncatingText, Select, and Combobox. - Select trigger drops `tw-shadow-elevation-000` for a flat surface. - Button gains `disabled:[&_svg]:tw-grayscale` / `disabled:[&_img]:tw-grayscale` so colored visuals desaturate when disabled. Lucide icons unaffected (already monochrome). - Rocket barrel exports TruncatingText. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(Rocket): add BoundedInHost stories for Combobox and Select Stories demonstrate the consumer-side pattern for popovers in narrow, right-aligned-trigger hosts (e.g. an inspector panel) without changing any Rocket primitives. Combobox uses align="end" + `!tw-w-max !tw-max-w-[<inner>px]` to grow leftward up to the host's inner width. Select uses the same recipe plus a scoped `:has()` CSS rule (inline in the story; in apps it goes in a component scss) that overrides Radix popper-wrapper `min-width: max-content`. Comments document why each piece is needed and how to translate it to a real consumer (subtract host padding for the cap, place the global rule once in the relevant scss file). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(Rocket): bound dropdown in Select LongSelectedValue story Adds the data-tj-fit-host marker, the !tw-w-max + !tw-max-w-[208px] classes, and the global :has() override so the Select dropdown stays within the 240px host (16px padding → 208px inner). Without these, Radix popper's wrapper enforces min-width: max-content and the dropdown expands to fit the longest option, leaving TruncatingText with no work to do — rows never clip. Combobox's LongOptionNames story did not need this fix: Base UI's shadcn Popup defaults to w-[var(--anchor-width)] so the dropdown already matches trigger width and TruncatingText clips rows. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(Rocket): allow SelectItem flex child to shrink for truncation Adds `[&>span:nth-child(2)]:tw-min-w-0` to the Rocket SelectItem CVA. Radix renders SelectItem children inside <SelectPrimitive.ItemText> (an inline span) which becomes a flex child of the Item. Default flex-item min-width: auto prevents it from shrinking below its intrinsic content width, which blocks any truncation primitive (e.g. TruncatingText, plain tw-truncate) inside from clipping. Setting min-width: 0 on that flex child is the standard "let me shrink" idiom and is inert when content fits naturally — no regression for any existing case. Lifting it once means consumers wrapping option labels in a clipping primitive don't need to repeat the selector at every callsite. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(Switch): adjust thumb translation values for better alignment --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: component overlapping when visibility set to false by default (#16089) * fix: input clicks route to wrong listview row (#16064) * fix: enhance descendant collection in prepareRowScope for ListView to support slot-based children (#16205) --------- Co-authored-by: Manish Kushare <37823141+manishkushare@users.noreply.github.com> Co-authored-by: Kartik Gupta <gupta.kartik18kg@gmail.com> Co-authored-by: Adish M <44204658+adishM98@users.noreply.github.com> Co-authored-by: Akshay <akshaysasidrn@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Shaurya Sharma <79473274+shaurya-sharma064@users.noreply.github.com> Co-authored-by: Souvik <psouvik260@gmail.com> Co-authored-by: Ganesh Kumar <40178541+ganesh8056@users.noreply.github.com> Co-authored-by: abhijeet760 <abhijeet@tooljet.com> Co-authored-by: gsmithun4 <gsmithun4@gmail.com> Co-authored-by: YuktiGoyal02 <100783212+YuktiGoyal02@users.noreply.github.com> Co-authored-by: Nakul Nagargade <133095394+nakulnagargade@users.noreply.github.com> Co-authored-by: Avinash <70191708+vavinash992@users.noreply.github.com> Co-authored-by: Devanshu Rastogi <devanshu.rastogi05@gmail.com> Co-authored-by: Kavin Venkatachalam <50441969+kavinvenkatachalam@users.noreply.github.com> Co-authored-by: Siddharth Pundir <145639697+Siddharthpl@users.noreply.github.com> Co-authored-by: Srimanitejas123 <mani@tooljet.com> Co-authored-by: Nithin David Thomas <1277421+nithindavid@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new data migration to backfill missing properties for
Tablecomponents in the database. The migration ensures that allTablecomponents have theshowRefreshButton,enableExpandableRows, andexpansionHeightproperties set, and cleans up related app history if any updates are made.Database migration for Table component properties:
BackfillRefreshButtonAndExpandableRowsForTable1776432217565) that iterates over allTablecomponents missing theshowRefreshButtonproperty and updates them to include default values forshowRefreshButton,enableExpandableRows, andexpansionHeight(server/data-migrations/1776432217565-BackfillRefreshButtonAndExpandableRowsForTable.ts).deleteAppHistoryForStructuralMigration).