Skip to content

Fix UPS OpenAPI spec rendering, GraphQL SSL handling, and false Snowflake table access warning#16538

Merged
johnsoncherian merged 4 commits into
chore/release-3.20.189-ltsfrom
fix/ups-openapi-render
Jun 29, 2026
Merged

Fix UPS OpenAPI spec rendering, GraphQL SSL handling, and false Snowflake table access warning#16538
johnsoncherian merged 4 commits into
chore/release-3.20.189-ltsfrom
fix/ups-openapi-render

Conversation

@ArnavMaggon2005

@ArnavMaggon2005 ArnavMaggon2005 commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Issue: #15974
Fix UPS OpenAPI Shipping spec rendering issue.

Root Cause

  • Malformed YAML in shipping.yaml caused OpenAPI spec parsing to fail
  • Missing frontend error handling caused infinite loading spinner

Changes

  • Fixed malformed YAML in shipping.yaml
  • Added proper error handling in ApiEndpointInput.jsx
  • Prevented infinite loading spinner when OpenAPI spec parsing fails
image


Issue: #15431
Fix GraphQL SSL handling with NODE_EXTRA_CA_CERTS.

Note

  • Verified the REST API plugin already contains the fix in the current codebase
  • While investigating the issue, the same unsafe pattern was identified and fixed in the GraphQL plugin.

Root Cause

  • GraphQL plugin assumed certificateAuthority always existed when NODE_EXTRA_CA_CERTS was set
  • ssl_certificate = 'none' created httpsParams.https without initializing certificateAuthority
  • Calling .concat() on undefined caused the datasource to crash

Changes

  • Added null-safe handling for certificateAuthority in GraphQL plugin
  • Prevented crashes when ssl_certificate = 'none' and NODE_EXTRA_CA_CERTS is configured
  • Preserved existing SSL behavior for other certificate modes

Issue: #16294
Snowflake GUI mode showed a false "You do not have access to the selected Table" warning after datasource switching when the table name was manually entered instead of fetched from the dropdown.

Root Cause

  • DynamicSelector validation treated absence of cached table metadata (undefined) the same as an empty fetched table list
  • Manually entered table names do not create table_cache until "Fetch Tables" is used
  • After datasource switching, validation incorrectly assumed missing cache meant the selected table was inaccessible
  • Backend query execution was unaffected because Snowflake queries use the raw table name directly

Changes

  • Updated DynamicSelector validation to distinguish between:
    • missing cache (manual entry without fetch)
    • fetched cache with unavailable tables
  • Skipped table-access validation when no cache exists for manually entered tables
  • Preserved existing warning behavior for genuinely inaccessible or unavailable tables
  • Prevented false-positive access warnings after datasource switching in Snowflake GUI mode

@netlify

netlify Bot commented May 22, 2026

Copy link
Copy Markdown

Deploy Preview for storybook-tooljet failed.

Name Link
🔨 Latest commit fc6b29a
🔍 Latest deploy log https://app.netlify.com/projects/storybook-tooljet/deploys/6a3e9ec7f298ad0008c290b1

@ArnavMaggon2005 ArnavMaggon2005 changed the title Fix: UPS OpenAPI spec rendering issue Fix UPS OpenAPI spec rendering, GraphQL SSL handling, and false Snowflake table access warning May 25, 2026
rudeUltra
rudeUltra previously approved these changes Jun 1, 2026
@Mekhla-Asopa Mekhla-Asopa added the create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile label Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

🚀 EE LTS Review App Deployed!

Resource Link
App URL https://tooljet-ee-lts-pr-16538.onrender.com
Render Dashboard https://dashboard.render.com/web/srv-d8frd819rddc73aqh7og

Deployed using DockerHub-based pipeline - LTS Edition

@github-actions github-actions Bot added active-ee-lts-review-app For lts (github action build and deploy on render)) and removed create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile labels Jun 3, 2026
@adishM98 adishM98 added the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 4, 2026
@github-actions github-actions Bot removed the active-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 4, 2026
@Mekhla-Asopa Mekhla-Asopa removed the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 16, 2026
@github-actions github-actions Bot added the active-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 16, 2026
@Mekhla-Asopa Mekhla-Asopa added deploy-marketplace-plugin and removed active-ee-lts-review-app For lts (github action build and deploy on render)) labels Jun 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Marketplace Plugin added to stage bucket

🔍 View Deployment Logs & Summary

━━━━━━━━━━━━━━━ UPLOAD SUMMARY ━━━━━━━━━━━━━━━━━
[8:55:29 AM] 🎉 All files uploaded successfully
[8:55:29 AM] ✅ Successfully uploaded: 576/576 files
[8:55:29 AM] ❌ Failed uploads: 0/576 files
[8:55:29 AM] ℹ Total time: 3.1s

@Mekhla-Asopa Mekhla-Asopa added create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile destroy-ee-lts-review-app For lts (github action build and deploy on render)) and removed marketplace-plugin-deployed create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile labels Jun 16, 2026
@github-actions github-actions Bot removed the destroy-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 16, 2026
@Mekhla-Asopa Mekhla-Asopa added deploy-marketplace-plugin create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile labels Jun 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚀 EE LTS Review App Deployed!

Resource Link
App URL https://tooljet-ee-lts-pr-16538.onrender.com
Render Dashboard https://dashboard.render.com/web/srv-d8oii84m0tmc73cq4d1g

Deployed using DockerHub-based pipeline - LTS Edition

@github-actions github-actions Bot added active-ee-lts-review-app For lts (github action build and deploy on render)) and removed create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile labels Jun 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Marketplace Plugin added to stage bucket

🔍 View Deployment Logs & Summary

━━━━━━━━━━━━━━━ UPLOAD SUMMARY ━━━━━━━━━━━━━━━━━
[10:47:52 AM] 🎉 All files uploaded successfully
[10:47:52 AM] ✅ Successfully uploaded: 576/576 files
[10:47:52 AM] ❌ Failed uploads: 0/576 files
[10:47:52 AM] ℹ Total time: 3.1s

@adishM98 adishM98 added the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 16, 2026
@github-actions github-actions Bot removed the destroy-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 23, 2026
@Mekhla-Asopa Mekhla-Asopa added the create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile label Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚀 EE LTS Review App Deployed!

Resource Link
App URL https://tooljet-ee-lts-pr-16538.onrender.com
Render Dashboard https://dashboard.render.com/web/srv-d8t2sgj6sc1c73e37rl0

Deployed using DockerHub-based pipeline - LTS Edition

@github-actions github-actions Bot added active-ee-lts-review-app For lts (github action build and deploy on render)) and removed create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile labels Jun 23, 2026
@adishM98 adishM98 added the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 23, 2026
@github-actions github-actions Bot removed the active-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 23, 2026
@ArnavMaggon2005 ArnavMaggon2005 force-pushed the fix/ups-openapi-render branch from 9aedd33 to 4497885 Compare June 25, 2026 08:31
@ArnavMaggon2005 ArnavMaggon2005 force-pushed the fix/ups-openapi-render branch from 4497885 to e1ffc7a Compare June 26, 2026 06:15
@Mekhla-Asopa Mekhla-Asopa removed the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 26, 2026
@github-actions github-actions Bot added the active-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 26, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ArnavMaggon2005
❌ YuktiGoyal02
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 EE LTS Review App Rebuilding

New commit fc6b29a pushed. Image updated and deployment triggered.

Using cached layers for faster build

@adishM98 adishM98 added the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 26, 2026
@github-actions github-actions Bot removed the active-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 26, 2026
@johnsoncherian johnsoncherian changed the base branch from lts-3.16 to chore/release-3.20.189-lts June 29, 2026 06:38
@johnsoncherian johnsoncherian merged commit 5950b7d into chore/release-3.20.189-lts Jun 29, 2026
188 of 193 checks passed
@johnsoncherian johnsoncherian deleted the fix/ups-openapi-render branch June 29, 2026 06:38
@github-actions github-actions Bot removed the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants