Skip to content

Prevent duplicate labels#46

Merged
adishM98 merged 1 commit intoToolJet:mainfrom
SorsOps:main
Feb 13, 2025
Merged

Prevent duplicate labels#46
adishM98 merged 1 commit intoToolJet:mainfrom
SorsOps:main

Conversation

@SorsOps
Copy link
Copy Markdown
Contributor

@SorsOps SorsOps commented Jan 13, 2025

Addresses #45

There are 2 real changes here and I am happy to amend based on feedback

  1. Changing the hardcoded tooljet-postgrest labels to rather rely on the release names instead so that multiple helm releases could be deployed into the same namespace
  2. Removing the selectorLabels from common labels as they do not appear to be common and are actually specific to the tooljet only portion of the system, not the "external" systems like postgrest. I've readded the selector labels to where ever I found the common labels to be used explicitly to prevent regression however

If anyone adds testing to this repo I'm happy to update to show that the labels should be as expected

@SorsOps
Copy link
Copy Markdown
Contributor Author

SorsOps commented Jan 30, 2025

@adishM98 bump

@adishM98
Copy link
Copy Markdown
Collaborator

@SorsOps Sure, Will test it once from our end and release it.

Copy link
Copy Markdown
Collaborator

@slancerk slancerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed.

@SorsOps
Copy link
Copy Markdown
Contributor Author

SorsOps commented Feb 7, 2025

@adishM98 Could you merge when you have time ?

@SorsOps
Copy link
Copy Markdown
Contributor Author

SorsOps commented Feb 11, 2025

@adishM98 bump

@adishM98 adishM98 merged commit fe2ccfa into ToolJet:main Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants