Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Temporal workflow scheduling by adding new Helm values, deploying a standalone worker, and provisioning a Temporal cluster alongside the main application.
- Added
workflow_envsection invalues.yamlfor workflow toggles and Temporal configuration - Created
workerdeployment & service templates to run workflows - Provisioned Temporal server and its PostgreSQL backend via
temporal.yml - Extended the main app’s deployment to include workflow-related environment variables
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/tooljet/values.yaml | Added workflow_env keys for enabling scheduling and addresses |
| charts/tooljet/templates/worker.yml | New Deployment template for the workflow worker |
| charts/tooljet/templates/worker-service.yml | New Service template for the workflow worker |
| charts/tooljet/templates/temporal.yml | Deployment, Service, and PVC for Temporal server & DB |
| charts/tooljet/templates/deployment.yaml | Injected workflow scheduling env vars into main app container |
Comments suppressed due to low confidence (5)
charts/tooljet/values.yaml:59
- The key
WORKFLOW_WORKERdoes not match the usage inworker.yml, which references.Values.workflow_env.WORKER. Rename one side for consistency (e.g., useWORKERin both places or update the template to referenceWORKFLOW_WORKER).
WORKFLOW_WORKER: "true"
charts/tooljet/templates/worker.yml:93
- This references
workflow_env.WORKER, butvalues.yamldefinesWORKFLOW_WORKER. Update the template to.Values.workflow_env.WORKFLOW_WORKER(or rename the key) to match.
value: {{ .Values.workflow_env.WORKER | quote }}
charts/tooljet/templates/worker-service.yml:8
- The service selector uses
component: tooljet-worker, but the Deployment labels usecomponent: worker. Update one side so the selector matches the pod label (e.g., usecomponent: worker).
component: tooljet-worker
charts/tooljet/templates/temporal.yml:1
- All resources in
temporal.ymlare unconditionally deployed. Consider wrapping the manifests in a Helmifblock on.Values.workflow_env.ENABLE_WORKFLOW_SCHEDULINGto avoid deploying Temporal when scheduling is disabled.
apiVersion: apps/v1
charts/tooljet/values.yaml:54
- [nitpick] Add comments or descriptions for each
workflow_envkey invalues.yamlto explain their purpose and acceptable values (e.g., explain whatWORKFLOW_WORKERtoggles).
workflow_env:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.