Skip to content

Feature/adding temporal#56

Merged
adishM98 merged 8 commits intomainfrom
feature/adding-temporal
Aug 26, 2025
Merged

Feature/adding temporal#56
adishM98 merged 8 commits intomainfrom
feature/adding-temporal

Conversation

@adishM98
Copy link
Copy Markdown
Collaborator

@adishM98 adishM98 commented Jul 7, 2025

No description provided.

@akshaysasidrn akshaysasidrn requested a review from Copilot July 10, 2025 08:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces Temporal workflow scheduling by adding new Helm values, deploying a standalone worker, and provisioning a Temporal cluster alongside the main application.

  • Added workflow_env section in values.yaml for workflow toggles and Temporal configuration
  • Created worker deployment & service templates to run workflows
  • Provisioned Temporal server and its PostgreSQL backend via temporal.yml
  • Extended the main app’s deployment to include workflow-related environment variables

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
charts/tooljet/values.yaml Added workflow_env keys for enabling scheduling and addresses
charts/tooljet/templates/worker.yml New Deployment template for the workflow worker
charts/tooljet/templates/worker-service.yml New Service template for the workflow worker
charts/tooljet/templates/temporal.yml Deployment, Service, and PVC for Temporal server & DB
charts/tooljet/templates/deployment.yaml Injected workflow scheduling env vars into main app container
Comments suppressed due to low confidence (5)

charts/tooljet/values.yaml:59

  • The key WORKFLOW_WORKER does not match the usage in worker.yml, which references .Values.workflow_env.WORKER. Rename one side for consistency (e.g., use WORKER in both places or update the template to reference WORKFLOW_WORKER).
  WORKFLOW_WORKER: "true"

charts/tooljet/templates/worker.yml:93

  • This references workflow_env.WORKER, but values.yaml defines WORKFLOW_WORKER. Update the template to .Values.workflow_env.WORKFLOW_WORKER (or rename the key) to match.
              value: {{ .Values.workflow_env.WORKER | quote }}

charts/tooljet/templates/worker-service.yml:8

  • The service selector uses component: tooljet-worker, but the Deployment labels use component: worker. Update one side so the selector matches the pod label (e.g., use component: worker).
    component: tooljet-worker

charts/tooljet/templates/temporal.yml:1

  • All resources in temporal.yml are unconditionally deployed. Consider wrapping the manifests in a Helm if block on .Values.workflow_env.ENABLE_WORKFLOW_SCHEDULING to avoid deploying Temporal when scheduling is disabled.
apiVersion: apps/v1

charts/tooljet/values.yaml:54

  • [nitpick] Add comments or descriptions for each workflow_env key in values.yaml to explain their purpose and acceptable values (e.g., explain what WORKFLOW_WORKER toggles).
workflow_env:

@adishM98 adishM98 merged commit 341bf08 into main Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants