Skip to content

PR_26175_CHARLIE_007-system-health-environment-identity#151

Merged
ToolboxAid merged 2 commits into
mainfrom
pr/26175-CHARLIE-007-system-health-environment-identity
Jun 24, 2026
Merged

PR_26175_CHARLIE_007-system-health-environment-identity#151
ToolboxAid merged 2 commits into
mainfrom
pr/26175-CHARLIE-007-system-health-environment-identity

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

Adds the current deployment Environment Identity section to Admin System Health and keeps the all-environment map as static reference content only.

Validation

  • node --check src/dev-runtime/server/local-api-router.mjs
  • node --check assets/theme-v2/js/admin-system-health.js
  • git diff --check
  • node --test tests/dev-runtime/AdminHealthOperations.test.mjs
  • npx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1 --reporter=line

Artifact

  • tmp/PR_26175_CHARLIE_007-system-health-environment-identity_delta.zip

No merge requested.

@ToolboxAid ToolboxAid marked this pull request as ready for review June 24, 2026 21:00
@ToolboxAid ToolboxAid merged commit 0e25639 into main Jun 24, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review


P2 Badge Use the approved /prod PRD storage lane

When the deployment uses the approved PRD storage prefix, loadStorageConfig only accepts /prod/projects/ (src/dev-runtime/storage/storage-config.mjs line 15), but this new model reports PRD as /prd. Because /prod is explicitly aliased to PRD later, a production health response can pass while displaying environmentIdentity.storageFolder: "/prd", and the reference map also tells operators to use a path that the storage config rejects.


if (["LOCAL", "DEV", "IST", "UAT", "PRD"].includes(upperValue)) {
return upperValue === "LOCAL" ? "Local" : upperValue;
}
if (upperValue === "PROD" || upperValue === "PRODUCTION") {
return "PRD";
}
if (upperValue.includes("LOCAL")) {
return "Local";
}
return "";

P2 Badge Recognize documented environment labels

When storage prefix is unset and the deployment relies on the documented GAMEFOUNDRY_ENVIRONMENT_LABEL values, this parser only recognizes short codes plus Production; the .env.example labels Development Environment, Integration Testing Environment, and User Acceptance Testing Environment fall through to the Local default. In those environments the new identity section reports the wrong current deployment instead of DEV/IST/UAT.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant